[SERVER-27866] The globalLockManager dump should print thread ID in decimal & hex Created: 31/Jan/17  Updated: 07/Sep/17  Resolved: 06/Mar/17

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: 3.4.4, 3.5.4

Type: Improvement Priority: Major - P3
Reporter: Jonathan Abrahams Assignee: Eddie Louie
Resolution: Done Votes: 0
Labels: bkp
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Related
related to SERVER-28198 Remove the decimal format for threadI... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v3.4
Sprint: TIG 2017-03-06, TIG 2017-03-27
Participants:

 Description   

The mongo::(anonymous namespace)::globalLockManager dump() function, invokes LockManager::_dumpBucket() to produce useful output for displaying locks and associated thread IDs. Since GDB prints out thread IDs in hex it hard to line them up. The dump should print out in both decimal and hex for this purpose.



 Comments   
Comment by Githook User [ 14/Apr/17 ]

Author:

{u'username': u'elouie99', u'name': u'Eddie Louie', u'email': u'eddie.louie@mongodb.com'}

Message: SERVER-27866 Add threadId dump in hex base from globalLockManager for PENDING locks

(cherry picked from commit 5a3082bc52cdcf8769021aa9256daabd43162a53)
Branch: v3.4
https://github.com/mongodb/mongo/commit/3835d1a8f710617a3a698572b3f9566db93686b1

Comment by Githook User [ 14/Apr/17 ]

Author:

{u'username': u'elouie99', u'name': u'Eddie Louie', u'email': u'eddie.louie@mongodb.com'}

Message: SERVER-27866 Add threadId dump in hex base from globalLockManager

(cherry picked from commit 203a0a831c15ff059a5399e28400a61bd1e5b3ae)
Branch: v3.4
https://github.com/mongodb/mongo/commit/799fff3a76373a15ff13f2e17f97293350701fd4

Comment by Githook User [ 06/Mar/17 ]

Author:

{u'username': u'elouie99', u'name': u'Eddie Louie', u'email': u'eddie.louie@mongodb.com'}

Message: SERVER-27866 Add threadId dump in hex base from globalLockManager for PENDING locks
Branch: master
https://github.com/mongodb/mongo/commit/5a3082bc52cdcf8769021aa9256daabd43162a53

Comment by Eddie Louie [ 03/Mar/17 ]

Code review url part 2: https://mongodbcr.appspot.com/116800001

Comment by Githook User [ 21/Feb/17 ]

Author:

{u'username': u'elouie99', u'name': u'Eddie Louie', u'email': u'eddie.louie@mongodb.com'}

Message: SERVER-27866 Add threadId dump in hex base from globalLockManager
Branch: master
https://github.com/mongodb/mongo/commit/203a0a831c15ff059a5399e28400a61bd1e5b3ae

Comment by Eddie Louie [ 18/Feb/17 ]

With my changes, the LockManager output looks like this:

[js_test:fsm_all_replication] 2017-02-17T19:30:20.048-0500 d20010| GRANTED:
[js_test:fsm_all_replication] 2017-02-17T19:30:20.048-0500 d20010| 	LockRequest 293 @ 0x5592FBF23000: Mode = X; Thread = 139740320216832 | 0x7f17d425b700; ConvertMode = NONE; EnqueueAtFront = 0; CompatibleFirst = 0;
[js_test:fsm_all_replication] 2017-02-17T19:30:20.048-0500 d20010| PENDING:
[js_test:fsm_all_replication] 2017-02-17T19:30:20.049-0500 d20010| 	LockRequest 294 @ 0x5592FBF23C00: Mode = S; Thread = 139739983456000; ConvertMode = NONE; EnqueueAtFront = 0; CompatibleFirst = 0;
[js_test:fsm_all_replication] 2017-02-17T19:30:20.049-0500 d20010| -----------------------------------------------------------
[js_test:fsm_all_replication] 2017-02-17T19:30:20.049-0500 d20010| 2017-02-17T19:30:20.047-0500 I -        [initandlisten] Lock @ 0x5592FA894E00: {2305843009213693953: Global, 1}
[js_test:fsm_all_replication] 2017-02-17T19:30:20.049-0500 d20010| GRANTED:
[js_test:fsm_all_replication] 2017-02-17T19:30:20.049-0500 d20010| 	LockRequest 297 @ 0x5592FAB6A400: Mode = IS; Thread = 139740372743936 | 0x7f17d7473700; ConvertMode = NONE; EnqueueAtFront = 0; CompatibleFirst = 0;
[js_test:fsm_all_replication] 2017-02-17T19:30:20.049-0500 d20010| 	LockRequest 294 @ 0x5592FBF23C00: Mode = IS; Thread = 139739983456000 | 0x7f17c0132700; ConvertMode = NONE; EnqueueAtFront = 0; CompatibleFirst = 0;
[js_test:fsm_all_replication] 2017-02-17T19:30:20.050-0500 d20010| 	LockRequest 293 @ 0x5592FBF23000: Mode = IS; Thread = 139740320216832 | 0x7f17d425b700; ConvertMode = NONE; EnqueueAtFront = 0; CompatibleFirst = 0;
[js_test:fsm_all_replication] 2017-02-17T19:30:20.050-0500 d20010| PENDING:
[js_test:fsm_all_replication] 2017-02-17T19:30:20.050-0500 d20010| -----------------------------------------------------------
[js_test:fsm_all_replication] 2017-02-17T19:30:20.050-0500 d20010| 2017-02-17T19:30:20.047-0500 I -        [initandlisten] Lock @ 0x5592FA894D00: {2305843009213693954: Global, 2}
[js_test:fsm_all_replication] 2017-02-17T19:30:20.050-0500 d20010| GRANTED:
[js_test:fsm_all_replication] 2017-02-17T19:30:20.050-0500 d20010| 	LockRequest 297 @ 0x5592FAB6A400: Mode = IS; Thread = 139740372743936 | 0x7f17d7473700; ConvertMode = NONE; EnqueueAtFront = 0; CompatibleFirst = 0;
[js_test:fsm_all_replication] 2017-02-17T19:30:20.050-0500 d20010| 	LockRequest 294 @ 0x5592FBF23C00: Mode = IS; Thread = 139739983456000 | 0x7f17c0132700; ConvertMode = NONE; EnqueueAtFront = 0; CompatibleFirst = 0;
[js_test:fsm_all_replication] 2017-02-17T19:30:20.051-0500 d20010| 	LockRequest 293 @ 0x5592FBF23000: Mode = IX; Thread = 139740320216832 | 0x7f17d425b700; ConvertMode = NONE; EnqueueAtFront = 0; CompatibleFirst = 0;
[js_test:fsm_all_replication] 2017-02-17T19:30:20.051-0500 d20010| PENDING:
[js_test:fsm_all_replication] 2017-02-17T19:30:20.051-0500 d20010| -----------------------------------------------------------
[js_test:fsm_all_replication] 2017-02-17T19:30:20.051-0500 d20010| 2017-02-17T19:30:20.047-0500 I -        [initandlisten] Lock @ 0x5592FA894C00: {8576409733318454219: Database, 1658880705677372363}
[js_test:fsm_all_replication] 2017-02-17T19:30:20.051-0500 d20010| GRANTED:
[js_test:fsm_all_replication] 2017-02-17T19:30:20.051-0500 d20010| 	LockRequest 294 @ 0x5592FBF23C00: Mode = S; Thread = 139739983456000 | 0x7f17c0132700; ConvertMode = NONE; EnqueueAtFront = 0; CompatibleFirst = 0;
[js_test:fsm_all_replication] 2017-02-17T19:30:20.051-0500 d20010| PENDING:
[js_test:fsm_all_replication] 2017-02-17T19:30:20.052-0500 d20010| 	LockRequest 293 @ 0x5592FBF23000: Mode = IX; Thread = 139740320216832; ConvertMode = NONE; EnqueueAtFront = 0; CompatibleFirst = 0;
[js_test:fsm_all_replication] 2017-02-17T19:30:20.052-0500 d20010| -----------------------------------------------------------
[js_test:fsm_all_replication] 2017-02-17T19:30:20.052-0500 d20010| 2017-02-17T19:30:20.047-0500 I -        [initandlisten] Lock @ 0x5592FAA9CB80: {7157799286721389413: Database, 240270259080307557}
[js_test:fsm_all_replication] 2017-02-17T19:30:20.052-0500 d20010| GRANTED:
[js_test:fsm_all_replication] 2017-02-17T19:30:20.052-0500 d20010| 	LockRequest 293 @ 0x5592FBF23000: Mode = X; Thread = 139740320216832 | 0x7f17d425b700; ConvertMode = NONE; EnqueueAtFront = 0; CompatibleFirst = 0;
[js_test:fsm_all_replication] 2017-02-17T19:30:20.052-0500 d20010| PENDING:
[js_test:fsm_all_replication] 2017-02-17T19:30:20.052-0500 d20010| 	LockRequest 297 @ 0x5592FAB6A400: Mode = IS; Thread = 139740372743936; ConvertMode = NONE; EnqueueAtFront = 0; CompatibleFirst = 0;
[js_test:fsm_all_replication] 2017-02-17T19:30:20.053-0500 d20010| -----------------------------------------------------------

Generated at Thu Feb 08 04:16:28 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.