[SERVER-27984] Add clang-tidy run in addition to lint Created: 13/Feb/17  Updated: 02/Feb/21  Resolved: 27/Sep/19

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: 4.3.1

Type: Improvement Priority: Major - P3
Reporter: Geert Bosch Assignee: Andrew Morrow (Inactive)
Resolution: Done Votes: 2
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-27897 Remove uses of temporary RAII objects Closed
Problem/Incident
Related
related to SERVER-49800 add use-after-move rule to clang-tidy... Closed
related to SERVER-50165 parallelize clang-tidy task Closed
related to SERVER-51240 Add clang tidy rules to prevent const... Closed
related to SERVER-54210 add clang-tidy to commit queue tasks Closed
Backwards Compatibility: Fully Compatible
Sprint: Dev Tools 2019-10-07
Participants:
Linked BF Score: 50

 Description   

As detailed in SERVER-27897, and the linked issues from there, unused RAII objects are often an indication of bugs. To avoid recurrence of this class of bugs, we need additional checking. As max.hirschhorn noted, `clang-tidy` provides just that: http://clang.llvm.org/extra/clang-tidy/checks/misc-unused-raii.html

This ticket is to add such checking.



 Comments   
Comment by Githook User [ 27/Sep/19 ]

Author:

{'name': 'Andrew Morrow', 'email': 'andrew.morrow@10gen.com'}

Message: SERVER-27984 Add minimal clang-tidy variant
Branch: master
https://github.com/mongodb/mongo/commit/e2875bb82ff99ffb27ccbcd68d596941a427f151

Comment by Andrew Morrow (Inactive) [ 13/Feb/17 ]

Longer term, I would like us to entirely replace cpplint with clang-tidy extended with our own custom checks.

Generated at Thu Feb 08 04:16:47 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.