[SERVER-27995] Make replication naming conventions consistent Created: 13/Feb/17 Updated: 07/Apr/17 Resolved: 14/Mar/17 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 3.4.4, 3.5.5 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Judah Schvimer | Assignee: | Judah Schvimer |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Backport Requested: |
v3.4
|
||||||||||||
| Sprint: | Repl 2017-03-06, Repl 2017-03-27 | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
Replication is filled with terrible naming choices, and many inconsistencies. We sometimes use "replset*" and sometimes use "repl_set*", we sometimes use "initialsync*" and sometimes use "initial_sync*". We also have terrible names like "BackgroundSync", which both is not descriptive and is in a file named "bgsync.cpp" instead of "background_sync.cpp". |
| Comments |
| Comment by Githook User [ 06/Apr/17 ] |
|
Author: {u'username': u'judahschvimer', u'name': u'Judah Schvimer', u'email': u'judah@mongodb.com'}Message: (cherry picked from commit 56b5dbbd9901152a0a185c766679bb3c355ebedd) |
| Comment by Githook User [ 06/Apr/17 ] |
|
Author: {u'username': u'judahschvimer', u'name': u'Judah Schvimer', u'email': u'judah@mongodb.com'}Message: (cherry picked from commit 5b5cf72ed9e52d71ed9f41b2219080fe46f62a3a) |
| Comment by Githook User [ 14/Mar/17 ] |
|
Author: {u'username': u'judahschvimer', u'name': u'Judah Schvimer', u'email': u'judah@mongodb.com'}Message: |
| Comment by Githook User [ 06/Mar/17 ] |
|
Author: {u'username': u'judahschvimer', u'name': u'Judah Schvimer', u'email': u'judah@mongodb.com'}Message: |
| Comment by Githook User [ 02/Mar/17 ] |
|
Author: {u'username': u'judahschvimer', u'name': u'Judah Schvimer', u'email': u'judah@mongodb.com'}Message: (cherry picked from commit f89ede4cc81a1307dec4b9e901fc91eb3f7f8992) |
| Comment by Githook User [ 02/Mar/17 ] |
|
Author: {u'username': u'judahschvimer', u'name': u'Judah Schvimer', u'email': u'judah@mongodb.com'}Message: (cherry picked from commit 068878410614c789f23b2abc6c5b9680c82abe5e) |
| Comment by Githook User [ 23/Feb/17 ] |
|
Author: {u'username': u'judahschvimer', u'name': u'Judah Schvimer', u'email': u'judah@mongodb.com'}Message: |
| Comment by Githook User [ 23/Feb/17 ] |
|
Author: {u'username': u'judahschvimer', u'name': u'Judah Schvimer', u'email': u'judah@mongodb.com'}Message: |
| Comment by Judah Schvimer [ 21/Feb/17 ] |
|
As of now we will not rename the DataReplicator to "InitialSyncer" since parts of it may be used for rollback. After the rollback work, we should revisit renaming the DataReplicator. What to rename the DataReplicatorExternalState if we rename the DataReplicator is also an open question. |
| Comment by Judah Schvimer [ 13/Feb/17 ] |
|
Now appears to be a good time to do this, both because our team is growing and because it will be an easy backport to 3.4, and 3.2 is already different enough from 3.4 that backports to 3.2 are already difficult. |