[SERVER-28008] Compress replies only when the request was compressed Created: 14/Feb/17 Updated: 27/Jun/22 Resolved: 24/Aug/17 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Networking |
| Affects Version/s: | None |
| Fix Version/s: | 3.5.13 |
| Type: | New Feature | Priority: | Major - P3 |
| Reporter: | Hannes Magnusson | Assignee: | Andrew Morrow (Inactive) |
| Resolution: | Done | Votes: | 0 |
| Labels: | neweng, platforms-interns-2017 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Sprint: | Platforms 2017-06-19, Platforms 2017-07-10, Platforms 2017-07-31, Platforms 2017-08-21, Platforms 2017-09-11 | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
Currently when compression is enabled, and negotiated in the initial handshake, all replies from the server will be compressed, regardless if the request coming into the server was compressed or not. There appears to be no way to toggle replies to be compressed or not. With snappy, this isn't much of an issue as compressing small data doesn't incur "to much overhead", but its a bit weird, and with zlib, this might be counterproductive. There should be a way for the request to determine if the reply should be compressed or not. |
| Comments |
| Comment by Ramon Fernandez Marina [ 24/Aug/17 ] |
|
Author: {'username': u'acmorrow', 'name': u'Andrew Morrow', 'email': u'acm@mongodb.com'}Message: |
| Comment by Ramon Fernandez Marina [ 24/Aug/17 ] |
|
Author: {'username': u'acmorrow', 'name': u'Andrew Morrow', 'email': u'acm@mongodb.com'}Message: |
| Comment by Jonathan Reams [ 19/Jun/17 ] |
|
As of This could be a good candidate for a neweng ticket. |
| Comment by Jonathan Reams [ 16/Jun/17 ] |
|
As part of this work we should add an integration test that makes sure the wire protocol messages sent/received are correct, and that the network counters get updated appropriately. |