[SERVER-28100] extend ReplSetTest.awaitNodesAgreeOnPrimary() to accept an optional expectedPrimaryIndex Created: 24/Feb/17  Updated: 06/Dec/17  Resolved: 17/May/17

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 3.2.14, 3.4.6, 3.5.8

Type: Improvement Priority: Major - P3
Reporter: Benety Goh Assignee: Benety Goh
Resolution: Done Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Related
related to SERVER-28676 [v3.4] minor_version_tags_old_new_old... Closed
Backwards Compatibility: Fully Compatible
Backport Completed:
Sprint: Repl 2017-04-17, Repl 2017-05-08, Repl 2017-05-29
Participants:
Linked BF Score: 0

 Description   

This will enable tests to wait until the replica set has stabilized with a specific node as primary.



 Comments   
Comment by Githook User [ 14/Jun/17 ]

Author:

{u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}

Message: SERVER-28100 ReplSetTest.awaitNodesAgreeOnPrimary() accepts an optional expectedPrimaryIndex

(cherry-picked from commit 8d146d21661cf755fc15b7eefec147ce85ffde8c)
Branch: v3.4
https://github.com/mongodb/mongo/commit/36f59e7d69ff1742ecaa4b71296bc553d5650b6d

Comment by Githook User [ 14/Jun/17 ]

Author:

{u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}

Message: SERVER-28100 moved common test code for all 3 tags.js tests into a test library under replsets/libs/

(cherry-picked from commit bcf3d946e680c2c5d8ba737bfb677af7bbc3eb3f)
Branch: v3.4
https://github.com/mongodb/mongo/commit/76a7e10984d940afb419acdbd2cff14acae0c271

Comment by Githook User [ 20/May/17 ]

Author:

{u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}

Message: SERVER-28100 ReplSetTest.awaitNodesAgreeOnPrimary() accepts an optional expectedPrimaryIndex

(cherry picked from commit 8d146d21661cf755fc15b7eefec147ce85ffde8c)
Branch: v3.2
https://github.com/mongodb/mongo/commit/d918f77b19767ce405db0641a5c65f3e66c26035

Comment by Githook User [ 20/May/17 ]

Author:

{u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}

Message: SERVER-28100 moved common test code for all 3 tags.js tests into a test library under replsets/libs/

(cherry picked from commit bcf3d946e680c2c5d8ba737bfb677af7bbc3eb3f)
Branch: v3.2
https://github.com/mongodb/mongo/commit/01e532f509e5214e0a35e3784033c653aa1af4df

Comment by Githook User [ 17/May/17 ]

Author:

{u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}

Message: SERVER-28100 ReplSetTest.awaitNodesAgreeOnPrimary() accepts an optional expectedPrimaryIndex
Branch: master
https://github.com/mongodb/mongo/commit/8d146d21661cf755fc15b7eefec147ce85ffde8c

Comment by Githook User [ 16/May/17 ]

Author:

{u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}

Message: SERVER-28100 moved common test code for all 3 tags.js tests into a test library under replsets/libs/
Branch: master
https://github.com/mongodb/mongo/commit/bcf3d946e680c2c5d8ba737bfb677af7bbc3eb3f

Comment by Benety Goh [ 24/Feb/17 ]

we also want the other nodes to get the heartbeats from the primary so that they will not run an election

Comment by Spencer Brody (Inactive) [ 24/Feb/17 ]

What would it do if the wrong primary is elected, just fail? In that case, could tests that care just add an "assert.eq(expectedPrimary, rst.getPrimary())"? I think that is clearer and simpler than expanding the scope of awaitNodesAgreeOnPrimary()

Generated at Thu Feb 08 04:17:07 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.