[SERVER-28134] Clean up header include order sensitivity Created: 27/Feb/17  Updated: 05/Apr/17  Resolved: 28/Feb/17

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 3.5.4

Type: Bug Priority: Major - P3
Reporter: Mathias Stearn Assignee: Mathias Stearn
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Repl 2017-03-06
Participants:

 Description   

All of our headers are supposed to be includable in any order. At least two cases aren't and need to be fixed:

  • itoa.h doesn't have #pragma once
  • remote_command_request/response.h must be included before unittest.h


 Comments   
Comment by Githook User [ 28/Feb/17 ]

Author:

{u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: SERVER-28134 Move operator<<(ostream, RemoteCommandRequest/Response) into executor namespace

This avoids clang errors if unittest.h is included before these headers.
Branch: master
https://github.com/mongodb/mongo/commit/2128f3a19f31ad31d97cb1ffec9a9320d641ff7c

Comment by Githook User [ 28/Feb/17 ]

Author:

{u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: SERVER-28134 add #pragma once to itoa.h
Branch: master
https://github.com/mongodb/mongo/commit/eed20a127f756ce537b9f33d83d4eb99f5d2ca0f

Generated at Thu Feb 08 04:17:13 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.