[SERVER-28155] Cleanup sharding library dependencies Created: 01/Mar/17  Updated: 05/Apr/17  Resolved: 01/Mar/17

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: 3.5.3
Fix Version/s: 3.4.3, 3.5.4

Type: Improvement Priority: Major - P3
Reporter: Kaloian Manassiev Assignee: Kaloian Manassiev
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
is depended on by SERVER-20854 Don't refresh database and collection... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v3.4
Sprint: Sharding 2017-03-06
Participants:
Linked BF Score: 0

 Description   

Sharding components include a lot of libraries because the files are scattered around. This ticket is to do a first pass cleanup to help with the caching changes needed for SERVER-20854.

In particular:

  • There should be no dependency on mongoscore other than mongos
  • There is no reason for the sharding unit-tests to use the egress metadata hooks
  • ChunkManagerTargeter is only used by the sharded write commands implementation so it should go under there
  • The haveLocalShardingInfo initializer is only used on mongod, so it should be there only.


 Comments   
Comment by Githook User [ 03/Mar/17 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-28155 Move DBClientMultiCommand to mongo/s/commands

(cherry picked from 962e21a702ffa6bb2e90df0b9f9dbd9b79c53f34)
Branch: v3.4
https://github.com/mongodb/mongo/commit/cd92ee40db9446ca5317eaeb81cdf47be7f00c3a

Comment by Githook User [ 03/Mar/17 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-28155 Move ChunkManagerTargeter in the sharding commands library

(cherry picked from commit 14c45cd2ddc67ecb3a21001dce416dd41eed5163)
Branch: v3.4
https://github.com/mongodb/mongo/commit/0453687cfd42029d91201d8092b760f65624ae0d

Comment by Githook User [ 03/Mar/17 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-28155 Remove usages of BSONSerializable outside of sharding

(cherry picked from commit a61cbeacfd3e5132ef5cb6774978f861033880bc)
Branch: v3.4
https://github.com/mongodb/mongo/commit/2c90ba1e6bbcb096f0d61e706b57b31a3d83d1f1

Comment by Githook User [ 02/Mar/17 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-28155 Fix broken UBSAN build
Branch: master
https://github.com/mongodb/mongo/commit/52bf1ac99bb82cf6cc78eb85363664011e8ae055

Comment by Githook User [ 01/Mar/17 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-28155 Get rid of the 'mongoscore' sharding library
Branch: master
https://github.com/mongodb/mongo/commit/962e21a702ffa6bb2e90df0b9f9dbd9b79c53f34

Comment by Githook User [ 01/Mar/17 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-28155 Get rid of the 'serveronly' sharding library

Fold its contents in the mongod-side of sharding.
Branch: master
https://github.com/mongodb/mongo/commit/605479fd4bb6b31fcc1e495d6bcf55234c0b68a4

Comment by Githook User [ 01/Mar/17 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-28155 Move ChunkManagerTargeter in the sharding commands library
Branch: master
https://github.com/mongodb/mongo/commit/14c45cd2ddc67ecb3a21001dce416dd41eed5163

Comment by Githook User [ 01/Mar/17 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-28155 Remove usages of BSONSerializable outside of sharding
Branch: master
https://github.com/mongodb/mongo/commit/a61cbeacfd3e5132ef5cb6774978f861033880bc

Comment by Kaloian Manassiev [ 01/Mar/17 ]

As part of this fix it is unlikely any cycles will be fixed, but we are getting closer to it. The reason to not try and break cycles is because I need to backport this change to 3.4 as part of SERVER-20854.

Generated at Thu Feb 08 04:17:16 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.