[SERVER-28225] SConstruct boost::shared_ptr check is done without injecting boost include path Created: 06/Mar/17  Updated: 06/Dec/17  Resolved: 22/Jun/17

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: 3.5.10

Type: Bug Priority: Major - P3
Reporter: Mathias Stearn Assignee: Tyler Kaye
Resolution: Done Votes: 0
Labels: neweng, platforms-interns-2017
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Platforms 2017-07-10
Participants:

 Description   

Since the third_party boost include path isn't injected when running CheckNullConversion it uses the system boost libraries or will fail if boost isn't installed to the system paths.

scons: Configure: Checking if implicit boost::shared_ptr null conversion is supported... 
build/ninja/scons/sconf_temp/conftest_26.cpp <-
  |
  |#include <boost/shared_ptr.hpp>
  |struct TestType { int value; bool boolValue; };
  |bool foo() {
  |    boost::shared_ptr<TestType> sp(new TestType);
  |    return NULL != sp;
  |}
  |
clang++ -o build/ninja/scons/sconf_temp/conftest_26.o -c -Woverloaded-virtual -Wpessimizing-move -Wredundant-move -Wno-undefined-var-template -Wa,--compress-debug-sections -gsplit-dwarf -fno-omit-frame-pointer -fno-strict-aliasing -ggdb -pthread -Wall -Wsign-compare -Wno-unknown-pragmas -Winvalid-pch -Werror -O2 -Wno-unused-local-typedefs -Wno-unused-function -Wno-unused-private-field -Wno-deprecated-declarations -Wno-tautological-constant-out-of-range-compare -Wno-unused-const-variable -Wno-missing-braces -Wno-inconsistent-missing-override -Wno-potentially-evaluated-expression -fstack-protector-strong -fPIE -DNDEBUG build/ninja/scons/sconf_temp/conftest_26.cpp
scons: Configure: yes
 



 Comments   
Comment by Githook User [ 22/Jun/17 ]

Author:

{u'username': u'tkaye407', u'name': u'Tyler Kaye', u'email': u'tyler.kaye@mongodb.com'}

Message: SERVER-28225 Removed boost::shared_pointer check in SConstruct
Branch: master
https://github.com/mongodb/mongo/commit/1517a5dd8382bf8c9fbe27940170867c081a1d03

Comment by Andrew Morrow (Inactive) [ 09/Mar/17 ]

I'm fairly sure that we no longer use boost::shared_ptr anywhere, so this check is obsolete and can be removed.

Generated at Thu Feb 08 04:17:31 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.