[SERVER-28354] Add new option to supply base process name in hang_analyzer Created: 16/Mar/17  Updated: 06/Dec/17  Resolved: 13/Apr/17

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: 3.4.5, 3.5.6

Type: New Feature Priority: Major - P3
Reporter: Jonathan Abrahams Assignee: Jonathan Abrahams
Resolution: Done Votes: 0
Labels: bkp
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Backwards Compatibility: Fully Compatible
Backport Requested:
v3.4
Sprint: TIG 2017-05-08
Participants:

 Description   

The hang_analyzer option -p uses a list of process name to decide what to analyze. If the process name mongo is supplied it will match on any process containing mongo, i.e., mongod. This uses a "greedy" process match, which is useful for matching unittests, i.e., _test.



 Comments   
Comment by Githook User [ 28/Apr/17 ]

Author:

{u'username': u'hptabster', u'name': u'Jonathan Abrahams', u'email': u'jonathan@mongodb.com'}

Message: SERVER-28354 Add new option to supply base process name in hang_analyzer

(cherry picked from commit 484f61548ce56e1b60c0019470ea46f2f4cfffca)
(cherry picked from commit 4677c2b4659ab634959d7866586cc9aaffa41745)
Branch: v3.4
https://github.com/mongodb/mongo/commit/43991ca92820fa9ea37e9eac852a5c0986356f95

Comment by Githook User [ 13/Apr/17 ]

Author:

{u'username': u'hptabster', u'name': u'Jonathan Abrahams', u'email': u'jonathan@mongodb.com'}

Message: SERVER-28354 Fix typo in help
Branch: master
https://github.com/mongodb/mongo/commit/4677c2b4659ab634959d7866586cc9aaffa41745

Comment by Githook User [ 13/Apr/17 ]

Author:

{u'username': u'hptabster', u'name': u'Jonathan Abrahams', u'email': u'jonathan@mongodb.com'}

Message: SERVER-28354 Add new option to supply base process name in hang_analyzer
Branch: master
https://github.com/mongodb/mongo/commit/484f61548ce56e1b60c0019470ea46f2f4cfffca

Comment by Jonathan Abrahams [ 10/Apr/17 ]

This code will be much simpler once BUILD-3083 has been implemented.

Comment by Max Hirschhorn [ 07/Apr/17 ]

This option is not intended to be used in Evergreen, but in the user's invocation

There's definitely some flexibility if the existing process name matching continues to be used in Evergreen. The other thing to keep in mind is that the processes are named along the lines of mongod-3.4 when running the multiversion suite.

Comment by Jonathan Abrahams [ 07/Apr/17 ]

I think having a new option which checks for a match on the base process name. This option is not intended to be used in Evergreen, but in the user's invocation. I'm thinking about invoking it as such:

buildscripts/hang_analyzer.py -p mongo,mongos -m exact

This would only match mongo & mongos processes, and not mongod

The current behavior will be invoked as follows (default value):

buildscripts/hang_analyzer.py -p mongo -m contains

Thiw would match mongo & mongos and mongod

Comment by Max Hirschhorn [ 07/Apr/17 ]

jonathan.abrahams, given that the nature of "greedy" matching on the process name is useful for attaching to any C++ unit tests, what are you propose as an alternative? I think there is an advantage to following similar semantics to the pkill command as the hang_analyzer.py script does now.

Generated at Thu Feb 08 04:17:53 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.