[SERVER-28390] Mark link targets as Precious when incremental linking flags are enabled Created: 19/Mar/17 Updated: 10/Apr/17 Resolved: 21/Mar/17 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Build |
| Affects Version/s: | None |
| Fix Version/s: | 3.2.13, 3.4.4, 3.5.4 |
| Type: | New Feature | Priority: | Major - P3 |
| Reporter: | Andrew Morrow (Inactive) | Assignee: | Andrew Morrow (Inactive) |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Backport Requested: |
v3.4, v3.2
|
||||
| Sprint: | Platforms 2017-03-27 | ||||
| Participants: | |||||
| Description |
|
SCons tries to unlink the output of link steps from the filesystem before running the link step for programs or libraries. Typically this is the right thing to do for safety, but it makes incremental linking impossible. We should add a mechanism that detects if the current build is already using incremental linking, and tags the relevant files as Precious so that SCons does not remove them first. |
| Comments |
| Comment by Githook User [ 10/Apr/17 ] |
|
Author: {u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}Message: (cherry picked from commit 21628d6b2311eb726c01244f6c5dba1edb1f6256) |
| Comment by Githook User [ 09/Apr/17 ] |
|
Author: {u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}Message: (cherry picked from commit 21628d6b2311eb726c01244f6c5dba1edb1f6256) |
| Comment by Andrew Morrow (Inactive) [ 21/Mar/17 ] |
|
This is a straightforward change that we should backport so that developers have consistent build behavior while moving between branches. |
| Comment by Githook User [ 21/Mar/17 ] |
|
Author: {u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}Message: |