[SERVER-28432] Move the key management out from TimeProofService Created: 22/Mar/17  Updated: 06/Dec/17  Resolved: 30/Mar/17

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 3.5.6

Type: Task Priority: Major - P3
Reporter: Misha Tyulenev Assignee: Jack Mulrow
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Sharding 2017-04-17
Participants:

 Description   

When sharding cluster starts up it needs to have the key for signing cluster time to be established.
However there is no need to block initialization of other services. Instead the blocking wait will be moved to the points when mongos needs to verify the signature and mongod needs to sign logicalTime.

1. Change TimeProofService c-tor signature to take no arguments
2. Change TimeProofService::getProof(const LogicalTime& key, const Key& key) (i.e. add a key arg)
3. Change TimeProofService::checkProof(const LogicalTime& time, const TimeProof& proof, const Key& key) (i.e. add a key arg)
4. Add a test only method that will install a temporary key that LogicalClock always pass to TPS.
5. Run all tests with the test-only method set the key to make sure that we dont break anything meanwhile.



 Comments   
Comment by Githook User [ 30/Mar/17 ]

Author:

{u'username': u'jsmulrow', u'name': u'Jack Mulrow', u'email': u'jack.mulrow@mongodb.com'}

Message: SERVER-28432 Move key management out from TimeProofService
Branch: master
https://github.com/mongodb/mongo/commit/325486685538d00adbd61f868c239b3ecc6938c6

Comment by Randolph Tan [ 24/Mar/17 ]

lgtm

Comment by Misha Tyulenev [ 24/Mar/17 ]

renctan Please ack the proposed changes.

Generated at Thu Feb 08 04:18:07 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.