[SERVER-28458] unit test the wall clock reset admin error Created: 23/Mar/17 Updated: 06/Dec/17 Resolved: 06/Jun/17 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 3.5.9 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Misha Tyulenev | Assignee: | Jack Mulrow |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Sharding 2017-05-29, Sharding 2017-06-19 |
| Participants: |
| Description |
|
The scenarios:
|
| Comments |
| Comment by Githook User [ 06/Jun/17 ] |
|
Author: {u'username': u'jsmulrow', u'name': u'Jack Mulrow', u'email': u'jack.mulrow@mongodb.com'}Message: |
| Comment by Misha Tyulenev [ 01/Jun/17 ] |
|
updated the ticket per discussion |
| Comment by Jack Mulrow [ 31/May/17 ] |
|
Also, right now the rate limiter only compares newly received times to the wall clock (here) and only errors if the new time is ahead of the wall clock. So even if a server's (wall clock time - cluster time) > maxDrift, as long as the newly received time is not maxDrift seconds past the wall clock time, it will still pass the rate limiter and be accepted by the clock. Should we update this ticket, or change the rate limiter? |
| Comment by Jack Mulrow [ 31/May/17 ] |
|
misha.tyulenev I noticed while looking at |