[SERVER-28465] Refactor eslint.py and clang_format.py Created: 23/Mar/17 Updated: 12/Apr/17 Resolved: 28/Mar/17 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 3.5.5 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Mark Benvenuto | Assignee: | Mark Benvenuto |
| Resolution: | Done | Votes: | 1 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Sprint: | Platforms 2017-04-17 | ||||||||
| Participants: | |||||||||
| Description |
|
The clang_format.py and eslint.py scripts share a lot of code. These have large amounts of duplicate code including the Repo class for using git, and the parallel_process function. This code should be de-duplicated and moved into separate python modules. Proposed Layout:
An example of why code de-duplication is bad is that the Repo class has diverged between these two files, and they now have different features. |
| Comments |
| Comment by Githook User [ 12/Apr/17 ] |
|
Author: {u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}Message: |
| Comment by Githook User [ 28/Mar/17 ] |
|
Author: {u'username': u'markbenvenuto', u'name': u'Mark Benvenuto', u'email': u'mark.benvenuto@mongodb.com'}Message: |