[SERVER-28605] Implement KeysCollectionDocument Created: 04/Apr/17 Updated: 05/Sep/18 Resolved: 07/Apr/17 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | 3.5.5 |
| Fix Version/s: | 3.5.6 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Randolph Tan | Assignee: | Jack Mulrow |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Sprint: | Sharding 2017-04-17 | ||||||||
| Participants: | |||||||||
| Description |
|
Implement class for parsing and serializing a admin.system.keys document:
|
| Comments |
| Comment by Githook User [ 07/Apr/17 ] | |
|
Author: {u'username': u'jsmulrow', u'name': u'Jack Mulrow', u'email': u'jack.mulrow@mongodb.com'}Message: | |
| Comment by Andy Schwerin [ 07/Apr/17 ] | |
|
OK. Let's refrain from writing parsers by hand in the future, in favor of autogeneration. | |
| Comment by Misha Tyulenev [ 06/Apr/17 ] | |
|
schwerin this CR is already lgtm - the only thing left it to push it. May be we can use IDL for the next jira where we need to parse any message so we dont need to reimplement the task? | |
| Comment by Randolph Tan [ 06/Apr/17 ] | |
|
schwerin I just talked with Mark and it looks like the current code in master has everything this work would need (assuming that it works perfectly). | |
| Comment by Andy Schwerin [ 05/Apr/17 ] | |
|
Would it be possible to use the new IDL to generate the parser and | |
| Comment by Andy Schwerin [ 05/Apr/17 ] | |
|
This might be a good candidate for using the new IDL to generate the parser and serializer. | |
| Comment by Misha Tyulenev [ 05/Apr/17 ] | |
|
Ok. I updated the spec. | |
| Comment by Randolph Tan [ 05/Apr/17 ] | |
|
Oh, yeah. I forgot to put static. We also need to be able to create new instances and serialize them to BSON (when creating new key documents) | |
| Comment by Misha Tyulenev [ 05/Apr/17 ] | |
|
overall lgtm:
| |
| Comment by Randolph Tan [ 04/Apr/17 ] | |
|
misha.tyulenev can you take a quick look at the description and let us know if you have any comments |