[SERVER-28752] Cleanup write commands construction and parsing Created: 12/Apr/17 Updated: 12/Oct/17 Resolved: 01/Aug/17 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 3.5.11 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Kaloian Manassiev | Assignee: | Kaloian Manassiev |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Sprint: | Sharding 2017-05-08, Sharding 2017-05-29, Sharding 2017-06-19, Sharding 2017-07-10, Sharding 2017-07-31, Sharding 2017-08-21 | ||||||||
| Participants: | |||||||||
| Linked BF Score: | 0 | ||||||||
| Description |
|
The classes which currently implement the construction and parsing logic for the insert/update/delete commands are very poorly structured, inefficient and difficult to extend. Since as part of the 'Retryable Writes' project we will need to extend the set of parameters they support, this might be a good time to implement them in IDL. Part of the work on this ticket should include a design of what the IDL parser should look like. Note that this task is not strictly necessary for 'Retryable Writes', but it would make the write commands more extensible. |
| Comments |
| Comment by Githook User [ 01/Aug/17 ] |
|
Author: {'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm', 'name': 'Kaloian Manassiev'}Message: This change gets rid of the legacy manual parsers for batched |
| Comment by Githook User [ 27/Jul/17 ] |
|
Author: {'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm', 'name': 'Kaloian Manassiev'}Message: |
| Comment by Githook User [ 27/Jul/17 ] |
|
Author: {'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm', 'name': 'Kaloian Manassiev'}Message: |
| Comment by Githook User [ 26/Jul/17 ] |
|
Author: {'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm', 'name': 'Kaloian Manassiev'}Message: Revert " This reverts commit 86defa9d193f34275af2c4f3c783dffb046182ff. |
| Comment by Githook User [ 26/Jul/17 ] |
|
Author: {'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm', 'name': 'Kaloian Manassiev'}Message: |
| Comment by Githook User [ 26/Jul/17 ] |
|
Author: {'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm', 'name': 'Kaloian Manassiev'}Message: In preparation for removing the Batched Insert/Update/Delete Request parser classes. |
| Comment by Githook User [ 24/Jul/17 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: |
| Comment by Githook User [ 19/Jul/17 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: |
| Comment by Githook User [ 19/Jul/17 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: |
| Comment by Githook User [ 19/Jul/17 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: |
| Comment by Githook User [ 06/Jul/17 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: |
| Comment by Githook User [ 06/Jul/17 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: |