[SERVER-28772] Create PushNode/PushAllNode Created: 12/Apr/17  Updated: 17/May/19  Resolved: 10/Aug/17

Status: Closed
Project: Core Server
Component/s: Querying
Affects Version/s: None
Fix Version/s: 3.5.12

Type: Task Priority: Major - P3
Reporter: Tess Avitabile (Inactive) Assignee: Justin Seyster
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-28621 Parse BSON update expression into an ... Closed
is depended on by SERVER-28777 Always parse update expression as an ... Closed
Documented
is documented by DOCS-10656 Docs for SERVER-28772: Create PushNod... Closed
Related
is related to CSHARP-2028 Remove $pushAll update modifier Closed
Backwards Compatibility: Minor Change
Sprint: Query 2017-07-10, Query 2017-07-31, Query 2017-08-21
Participants:

 Description   

Create PushNode/PushAllNode implementing UpdateLeafNode. Ensure we can parse $push/$pushAll to a PushNode/PushAllNode.



 Comments   
Comment by Githook User [ 10/Aug/17 ]

Author:

{'name': 'Justin Seyster', 'username': 'jseyster', 'email': 'justin.seyster@mongodb.com'}

Message: SERVER-28772 Remove the $pushAll modifier.

The $pushAll modifier was deprecated and is now unsupported. Clients
should switch to the $push modifier with $each to get $pushAll
behavior.

This patch also updates some copyright notices that should have been
updated as part of file renames in bf99c6.
Branch: master
https://github.com/mongodb/mongo/commit/5368ddee0e72af3283e2591f751a5b79925e64d0

Comment by Githook User [ 09/Aug/17 ]

Author:

{'username': 'jseyster', 'email': 'justin.seyster@mongodb.com', 'name': 'Justin Seyster'}

Message: SERVER-28772 PushNode

A later commit will remove support for the deprecated $pushAll.
Branch: master
https://github.com/mongodb/mongo/commit/bf99c6ff2fbd95590aa86818c07b9bc121557f06

Comment by Justin Seyster [ 01/Aug/17 ]

We decided that, in addition to not implementing $pushAll in the new update system, we should also remove it completely. I will be deleting the $pushAll implementation along with its tests as part of this ticket.

Comment by Justin Seyster [ 26/Jul/17 ]

tess.avitabile Yes, that's right. I am only implementing $push.

Comment by Tess Avitabile (Inactive) [ 26/Jul/17 ]

justin.seyster, I wanted to confirm that you are not planning to implement $pushAll in the new system.

Comment by Tess Avitabile (Inactive) [ 28/Jun/17 ]

Since $pushAll was deprecated in 2.4, we do not need to implement it in the new implementation. We should file a DOCS ticket for the compatibility notes and for removing $pushAll from the 3.6 documentation.

Generated at Thu Feb 08 04:19:00 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.