[SERVER-28799] Don't dereference the boost::optional<MigrationSessionId> maintained by MigrationDestinationManager unless it is known to be set Created: 14/Apr/17  Updated: 12/Oct/17  Resolved: 15/Apr/17

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 3.5.6

Type: Bug Priority: Major - P3
Reporter: Dianna Hohensee (Inactive) Assignee: Dianna Hohensee (Inactive)
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Sharding 2017-05-08
Participants:
Linked BF Score: 0

 Description   

Discovered in BF-5146 fuzzer test. We can dereference MigrationDestionationManager::_sessionId, a boost::optional<MigrationSessionId>, when it is unset: https://github.com/mongodb/mongo/blob/ed80d2d3c5735c424e5c1cd58169077327976d2e/src/mongo/db/s/migration_destination_manager.cpp#L356

Backports are not needed, as the log message in which _sessionId is dereferenced is new as of v3.5



 Comments   
Comment by Githook User [ 15/Apr/17 ]

Author:

{u'username': u'DiannaHohensee', u'name': u'Dianna Hohensee', u'email': u'dianna.hohensee@10gen.com'}

Message: SERVER-28799 prevent possible dereference of unset boost::optional<MigrationSessionId> in MigrationDestinationManager::startCommit
Branch: master
https://github.com/mongodb/mongo/commit/1709b89ad4aa8b5501719493b875e581ceac0c78

Generated at Thu Feb 08 04:19:05 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.