[SERVER-28814] Eliminate ServerSelectionMetadata in favor of just using ReadPreferenceSetting Created: 14/Apr/17 Updated: 06/Aug/18 Resolved: 12/May/17 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Networking, Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 3.5.7 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Mathias Stearn | Assignee: | Mathias Stearn |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Sprint: | Repl 2017-05-08, Repl 2017-05-29 | ||||||||
| Participants: | |||||||||
| Linked BF Score: | 0 | ||||||||
| Description |
|
ServerSelectionMetadata is just a ReadPreferenceSetting + secondaryOk. Since secondaryOk is equivalent to ReadPreference SecondaryPreferred, it is simpler to translate it so we have a single source of truth. This is part of the OP_MSG spec which specifies using $readPreference rather than $ssm. The $ssm metadata field will still be used when communicating with 3.4 nodes over OP_COMMAND, but it will be translated at the border. As part of this work, ReadPreferenceSetting will be attached to the OperationContext on mongos in the same way that it is in mongod. |
| Comments |
| Comment by Githook User [ 12/May/17 ] |
|
Author: {u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}Message: |
| Comment by Githook User [ 12/May/17 ] |
|
Author: {u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}Message: |
| Comment by Githook User [ 12/May/17 ] |
|
Author: {u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}Message: |
| Comment by Githook User [ 12/May/17 ] |
|
Author: {u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}Message: Every caller was already using uassertStatusOK. Moving that into the |
| Comment by Githook User [ 12/May/17 ] |
|
Author: {u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}Message: |
| Comment by Githook User [ 12/May/17 ] |
|
Author: {u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}Message: This eliminates the need to pass it in to Command::explain() |
| Comment by Githook User [ 12/May/17 ] |
|
Author: {u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}Message: |
| Comment by Githook User [ 12/May/17 ] |
|
Author: {u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}Message: This is prep for eliminating ServerSelectionMetadata in favor of just |