[SERVER-28821] MozJS ASAN integration should not invariant that all memory was freed Created: 17/Apr/17  Updated: 12/Oct/17  Resolved: 17/Apr/17

Status: Closed
Project: Core Server
Component/s: Diagnostics
Affects Version/s: None
Fix Version/s: 3.4.10, 3.5.6

Type: Improvement Priority: Major - P3
Reporter: Andrew Morrow (Inactive) Assignee: Andrew Morrow (Inactive)
Resolution: Done Votes: 0
Labels: bkp
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Backwards Compatibility: Fully Compatible
Backport Requested:
v3.4
Sprint: Platforms 2017-04-17, Platforms 2017-05-08
Participants:
Linked BF Score: 0

 Description   

In our MozJS integration, we track allocations in a shadow data structure so that ASAN can see reachability. During teardown, we assert that all allocations recorded in that data structure have been freed. However, doing so means that if we actually have a leak, we will hard terminate before we give the leak checker a chance to report leaks.



 Comments   
Comment by Githook User [ 02/Oct/17 ]

Author:

{'email': 'acm@mongodb.com', 'name': 'Andrew Morrow', 'username': 'acmorrow'}

Message: SERVER-28821 Dont require leak free execution before the leak checker runs

(cherry picked from commit e2ede4bf04b485955a2c32cfe1eb12a6ac2a6014)
Branch: v3.4
https://github.com/mongodb/mongo/commit/08e4f211a90f8c8db5ad796479e17b3a2ecb201c

Comment by Andrew Morrow (Inactive) [ 17/Apr/17 ]

Since SERVER-22520 went back to 3.4, so should this fix.

Comment by Githook User [ 17/Apr/17 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-28821 Dont require leak free execution before the leak checker runs
Branch: master
https://github.com/mongodb/mongo/commit/e2ede4bf04b485955a2c32cfe1eb12a6ac2a6014

Generated at Thu Feb 08 04:19:09 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.