[SERVER-28871] Remove write concern error backwards compatibility for user management commands Created: 19/Apr/17 Updated: 30/Oct/23 Resolved: 03/Dec/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Security |
| Affects Version/s: | None |
| Fix Version/s: | 4.1.6 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Spencer Brody (Inactive) | Assignee: | Spencer Jackson |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | platforms_security, writeconcern | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Backwards Compatibility: | Minor Change | ||||||||||||||||
| Sprint: | Dev Tools 2018-10-22, Dev Tools 2018-11-05, Security 2018-12-03, Security 2018-12-17 | ||||||||||||||||
| Participants: | |||||||||||||||||
| Linked BF Score: | 0 | ||||||||||||||||
| Description |
|
Generally speaking, when a command succeeds but fails waiting for write concern, the command response indicates ok:1, but has a writeConcernError field. When we made it so all commands that write can accept write concern, we finally standardized on that method of reporting write concern errors. User management commands, however, already supported write concern, and they reported errors differently - a failed write concern for them caused the whole command to report ok:0. In 3.4 we continued to provide that behavior for user management commands to preserve backwards compatibility until drivers were all updated to know to always check for the presence of the writeConcernError field. Now that it's been a full release since we made that change, we should be able to remove this bandaid and have user management commands handle write concern errors the same way as any other command. The bandaid code exists here, and already has a TODO to remove it. |
| Comments |
| Comment by Githook User [ 03/Dec/18 ] |
|
Author: {'name': 'Spencer Jackson', 'email': 'spencer.jackson@mongodb.com', 'username': 'spencerjackson'}Message: |
| Comment by Billy Donahue [ 25/Apr/18 ] |
|
We should do this change but do it early in the 4.1 cycle, not as a last minute change to a 4.0 rc. |
| Comment by Githook User [ 25/Apr/18 ] |
|
Author: {'email': 'dennis.khodyakov@mongodb.com', 'name': 'Denis Khodyakov'}Message: Revert " This reverts commit 76bc4f800ba2a103d67fa4600d3946f255927818. |
| Comment by Githook User [ 24/Apr/18 ] |
|
Author: {'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue', 'name': 'Billy Donahue'}Message: |
| Comment by Billy Donahue [ 24/Apr/18 ] |