[SERVER-28887] Cleanup KeysCollectionCacheReader/AndUpdater Created: 20/Apr/17  Updated: 30/Oct/23  Resolved: 31/Jan/18

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: 3.5.7
Fix Version/s: 3.7.2

Type: Task Priority: Major - P3
Reporter: Randolph Tan Assignee: Blake Oler
Resolution: Fixed Votes: 0
Labels: PM-221, neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Sharding 2018-02-12
Participants:

 Description   

This refactor ticket aims to split KeysCollectionCacheReaderAndUpdater into KeyGenerator and KeysCollectionCacheReader. To achieve this, we need to:

  • Remove existing KeysCollectionCache.
  • rename KeysCollectionCacheReader to KeysCollectionCache
  • rename KeysCollectionCacheReaderAndUpdater to KeyGenerator
  • change existing code in KeysCollectionManager to always have a KeysCollectionCache and create a KeyGenerator in here and destroy in here

change KeysCollectionCacheReaderAndUpdater to the following api:

class KeyGenerator {
    Status generateNewKeysIfNeeded(OperationContext* opCtx);
    // removed the getKey methods, existing callers should call the KeysCollectionCache instance instead.
};



 Comments   
Comment by Githook User [ 31/Jan/18 ]

Author:

{'email': 'blake.oler@mongodb.com', 'name': 'Blake Oler', 'username': 'BlakeIsBlake'}

Message: SERVER-28887 Cleanup KeysCollectionCacheReader/AndUpdater
Branch: master
https://github.com/mongodb/mongo/commit/0fb3ff2ee1fc5305b9523cdeaaae9c7279f1c117

Generated at Thu Feb 08 04:19:20 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.