[SERVER-28888] libdeps dependency order unstable without --implicit-cache Created: 20/Apr/17  Updated: 30/Oct/23  Resolved: 21/Apr/17

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: 3.5.7

Type: Bug Priority: Major - P3
Reporter: Andrew Morrow (Inactive) Assignee: Andrew Morrow (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Steps To Reproduce:

Build any target without -implicitcache, then rebuild with -debug=explain.

Sprint: Platforms 2017-05-08
Participants:

 Description   

In SERVER-27505, we added support for topsorting our libraries. As part of that change, we stopped sorting the results reported by the scanner:

https://github.com/mongodb/mongo/commit/190dcaab71bcca027954e227ac73a36958aab762#diff-d90fa2623f9db54079c913e56e6183e0R188

That caused the dependency orders to change run-to-run, unless you were building with --implicit-cache. Since most users do build that way, we didn't notice.

The solution is to simply append the results in the stable order returned by __get_libdeps.



 Comments   
Comment by Githook User [ 21/Apr/17 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-28888 Ensure scanner stability across rebuilds

Also, a quick fix to eliminate a needless sort, since Node.sources
is expected to be stable across rebuilds, unlike Node.sources_set
Branch: master
https://github.com/mongodb/mongo/commit/ab0fc1ebb4df846367d409e0223a085e0db1b98e

Generated at Thu Feb 08 04:19:20 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.