[SERVER-28897] Update apply_ops1.js to only perform idempotent operations in applyOps Created: 21/Apr/17  Updated: 30/Oct/23  Resolved: 06/Jun/17

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 3.5.9

Type: Task Priority: Major - P3
Reporter: Siyuan Zhou Assignee: Matthew Russotto
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Related
related to SERVER-27096 applyOps should validate its ops to e... Backlog
is related to SERVER-27092 blacklist apply_ops1.js from dynamic ... Closed
Backwards Compatibility: Fully Compatible
Sprint: Repl 2017-06-19
Participants:
Linked BF Score: 0

 Description   

apply_ops1.js is not idempotent so we cannot re-apply it on restart.



 Comments   
Comment by Githook User [ 06/Jun/17 ]

Author:

{u'username': u'mtrussotto', u'name': u'Matthew Russotto', u'email': u'matthew.russotto@10gen.com'}

Message: SERVER-28897 Update apply_ops1.js to only perform idempotent operations in applyOps
Branch: master
https://github.com/mongodb/mongo/commit/080e4a8b916721e143968943201655735049c4ba

Comment by Spencer Brody (Inactive) [ 21/Apr/17 ]

I think the real problem is that the apply_ops1.js test performs non-idempotent applyOps commands, which is illegal behavior. Once SERVER-27096 is complete those operations will fail. In the meantime we should probably update apply_ops1.js to only perform idempotent applyOps.

Comment by Eric Milkie [ 21/Apr/17 ]

After geert.bosch commits his work for SERVER-27989 in a few days, renameCollection will be a lot more solid. I'm not sure if it's idempotent today though.

Comment by Max Hirschhorn [ 21/Apr/17 ]

milkie, redbeard0531, should tests that run the "renameCollection" command also not be run as part of the replica_sets_kill_secondaries_jscore_passthrough suite? Siyuan and I weren't sure what would happened if you killed the server while it was part-way through applying the "renameCollection" command.

Generated at Thu Feb 08 04:19:22 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.