[SERVER-28931] One-line Omission in New Range Deleter patch Created: 23/Apr/17  Updated: 30/Oct/23  Resolved: 23/Apr/17

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: 3.5.7
Fix Version/s: 3.5.7

Type: Bug Priority: Critical - P2
Reporter: Nathan Myers Assignee: Nathan Myers
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Participants:

 Description   

A line was accidentally deleted in the New Range Deleter patch:

diff --git a/src/mongo/db/s/metadata_manager.cpp b/src/mongo/db/s/metadata_manager.cpp
index faa062e..b582186 100644
--- a/src/mongo/db/s/metadata_manager.cpp
+++ b/src/mongo/db/s/metadata_manager.cpp
@@ -114,9 +223,7 @@ void MetadataManager::refreshActiveMetadata(std::unique_ptr<CollectionMetadata>
               << remoteMetadata->toStringBasic() << " due to epoch change";
 
         _receivingChunks.clear();
-        _rangesToClean.clear();
-
-        _setActiveMetadata_inlock(std::move(remoteMetadata));
+        _rangesToClean.clear(Status::OK());
         return;
     }

It needs to be restored.



 Comments   
Comment by Githook User [ 23/Apr/17 ]

Author:

{u'username': u'nathan-myers-mongo', u'name': u'Nathan Myers', u'email': u'nathan.myers@10gen.com'}

Message: SERVER-28931 Restore omitted line in MetadataManager::refreshActiveMetadata
Branch: master
https://github.com/mongodb/mongo/commit/13153510db12236bd06c13b5138cb9b07998016b

Comment by Nathan Myers [ 23/Apr/17 ]

https://evergreen.mongodb.com/version/58fc572b2fbabe08f10007e1

Generated at Thu Feb 08 04:19:27 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.