[SERVER-28960] Unittest "death tests" should not dump core Created: 25/Apr/17 Updated: 30/Oct/23 Resolved: 26/May/17 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Testing Infrastructure |
| Affects Version/s: | None |
| Fix Version/s: | 3.4.6, 3.5.8 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Jonathan Abrahams | Assignee: | Max Hirschhorn |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Backport Requested: |
v3.4
|
||||||||||||
| Sprint: | TIG 2017-05-29, TIG 2017-06-19 | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
The unittests which run "death tests" should not produce a core dump. Logic to prevent the core dump from fassert, invariant or abort could be controlled by a compiler macro or environment variable. |
| Comments |
| Comment by Githook User [ 17/Jun/17 ] |
|
Author: {u'username': u'visemet', u'name': u'Max Hirschhorn', u'email': u'max.hirschhorn@mongodb.com'}Message: (cherry picked from commit 28f0d02a151ab867ae04c314c11cef0295af289a) |
| Comment by Githook User [ 26/May/17 ] |
|
Author: {u'username': u'visemet', u'name': u'Max Hirschhorn', u'email': u'max.hirschhorn@mongodb.com'}Message: |
| Comment by Githook User [ 26/May/17 ] |
|
Author: {u'username': u'visemet', u'name': u'Max Hirschhorn', u'email': u'max.hirschhorn@mongodb.com'}Message: |
| Comment by Andy Schwerin [ 01/May/17 ] |
|
I think suppressing core dumps in the DEATH_TEST subprocess makes a lot of sense. DEATH_TEST also needs to be ported to support Windows at some point, which will involve introducing command line arguments and other changes that might make this easier. See |
| Comment by Max Hirschhorn [ 27/Apr/17 ] |
|
schwerin does it seem reasonable to you to make it so that DEATH_TEST sets a macro that makes the signal_handler.cpp not dump a core? |