[SERVER-28992] Cleanup mongos write commands execution Created: 26/Apr/17 Updated: 30/Oct/23 Resolved: 22/Dec/17 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 3.6.2, 3.7.1 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Kaloian Manassiev | Assignee: | Kaloian Manassiev |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Backport Requested: |
v3.6
|
||||
| Sprint: | Sharding 2017-05-08, Sharding 2017-05-29, Sharding 2017-06-19, Sharding 2018-01-01 | ||||
| Participants: | |||||
| Description |
|
The mongos write commands execution is overly complex, manages bare pointers and swaths of memory. This ticket is to combine any miscellaneous cleanup which can be done to simplify them. |
| Comments |
| Comment by Githook User [ 29/Dec/17 ] |
|
Author: {'name': 'Kaloian Manassiev', 'username': 'kaloianm', 'email': 'kaloian.manassiev@mongodb.com'}Message: No functional changes, just getting rid of some unnecessary overhead.
(cherry picked from commit 890051d8166e668442aff70cfcde3cb71ae6115f) |
| Comment by Githook User [ 29/Dec/17 ] |
|
Author: {'name': 'Kaloian Manassiev', 'username': 'kaloianm', 'email': 'kaloian.manassiev@mongodb.com'}Message: ... instead of populating arrays of pointers. This saves both on memory |
| Comment by Githook User [ 29/Dec/17 ] |
|
Author: {'name': 'Kaloian Manassiev', 'username': 'kaloianm', 'email': 'kaloian.manassiev@mongodb.com'}Message: |
| Comment by Githook User [ 22/Dec/17 ] |
|
Author: {'username': 'kaloianm', 'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com'}Message: No functional changes, just getting rid of some unnecessary overhead.
|
| Comment by Githook User [ 29/Apr/17 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: ... instead of a dynamically allocated array and in-place |
| Comment by Githook User [ 27/Apr/17 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: There is no need for that structure to be dynamically allocated or to even |
| Comment by Githook User [ 27/Apr/17 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message:
|