[SERVER-29054] stdx::hash Created: 03/May/17 Updated: 10/Jul/19 Resolved: 10/Jul/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Samantha Ritter (Inactive) | Assignee: | Andrew Morrow (Inactive) |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Sprint: | Platforms 2018-01-01, Dev Tools 2019-07-01, Dev Tools 2019-07-15 | ||||||||
| Participants: | |||||||||
| Description |
|
We should add a stdx::hash to the server, which would be std::hash on all non-windows platforms, and boost::hash on windows, to match our stdx-ing of unordered_map. |
| Comments |
| Comment by Andrew Morrow (Inactive) [ 10/Jul/19 ] |
|
Per recent discussion, the divergence in implementations of things stdx::unordered_ has gone away, removing the motivation for this ticket. |
| Comment by ADAM Martin (Inactive) [ 21/Jun/19 ] |
|
Now that `stdx::unordered_map` and `stdx::unordered_set` are hash table implementations from Abseil, we will need a different approach for this. Abseil appears capable of using the hash function defined in `std::hash` for its internals. We should discuss whether we want to also make a `stdx::hash` to sit alongside `stdx::unordered_map`. While `stdx::unordered_map` is supposed to work like `std::unordered_map`, it might be more inline with the mission of `stdx::` to bring all user-customization points also into the same namespace, when a `std::` component is provided in the `stdx::` namespace. |