[SERVER-29195] Some JS comments need their text reflowed to 100 characters after clang-format Created: 15/May/17  Updated: 27/Sep/18  Resolved: 27/Sep/18

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Minor - P4
Reporter: Eric Milkie Assignee: DO NOT USE - Backlog - Test Infrastructure Group (TIG)
Resolution: Won't Fix Votes: 0
Labels: clang-format, close
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Operating System: ALL
Participants:

 Description   

In the commit for SERVER-22469, C-style comments rewrapped correctly, but C++-style comments came out looking like (e.g. db.js):

        // We have special handling for the 'flags' field, and provide sugar for specific flags. If
        // the
        // user specifies any flags we send the field in the command. Otherwise, we leave it blank
        // and
        // use the server's defaults.

and

    ////////////////////////////////////////////////////////////////////////////////////////////////////
    //////////////////////////// Security shell helpers below
    /////////////////////////////////////////////
    ////////////////////////////////////////////////////////////////////////////////////////////////////



 Comments   
Comment by Max Hirschhorn [ 16/May/17 ]

When clang-format wraps multiple lines that are over 100 characters onto separate lines, each wrapped at 100 characters. This behavior was known and was something that Mark worked around in SERVER-18978. We can try and use a script similar to

find . -regextype posix-egrep -regex ".*\.(cpp|h)" | grep -v rlp_decls | xargs -I{}  grep -H --color '.\{101\}' {} | wc -l

to identify any other lines that should be reflowed.

Generated at Thu Feb 08 04:20:09 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.