[SERVER-29200] Limit access to OplogEntry::raw Created: 15/May/17  Updated: 30/Oct/23  Resolved: 16/Jan/18

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 3.7.2

Type: Improvement Priority: Major - P3
Reporter: Judah Schvimer Assignee: Benety Goh
Resolution: Fixed Votes: 0
Labels: neweng, todo_in_code
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-31356 make OplogEntry immutable Closed
related to SERVER-32728 SyncTail::syncApply should accept Opl... Backlog
Backwards Compatibility: Fully Compatible
Sprint: Repl 2018-01-29
Participants:

 Description   

(1/16/2018 update) SyncTail::raw still refers to this field. This work is captured in SERVER-32728.


The public "raw" member is used in a lot of places. It should be made private and replaced with specific helper functions.



 Comments   
Comment by Githook User [ 16/Jan/18 ]

Author:

{'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}

Message: SERVER-29200 remove references to OplogEntry::raw from MultiApplier
Branch: master
https://github.com/mongodb/mongo/commit/f2af0ad889f1cfca7a311d53912c5b808500ea77

Comment by Githook User [ 16/Jan/18 ]

Author:

{'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}

Message: SERVER-29200 migrate SyncTail::getMissingDoc() and fetchAndInsertMissingDoc() to accept OplogEntry instead of BSONObj
Branch: master
https://github.com/mongodb/mongo/commit/25f0c6ae6c4fa80244cadb8a6bfcbf9bcc8b7742

Comment by Githook User [ 16/Jan/18 ]

Author:

{'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}

Message: SERVER-29200 add OplogEntry::getOperationToApply()

remove references to OplogEntry::raw from rollback, prefetchPagesForReplicatedOp() and SyncTail
Branch: master
https://github.com/mongodb/mongo/commit/939a30aba1703c939b0352bded4b56257c8a0bec

Comment by Githook User [ 16/Jan/18 ]

Author:

{'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}

Message: SERVER-29200 add OplogEntry::getRawObjSizeBytes()

remove references to OplogEntry::raw from SyncTail::OpQueue and InitialSyncer
Branch: master
https://github.com/mongodb/mongo/commit/1378f8ec42068913c5bdc5927bbe86d5aed08814

Comment by Benety Goh [ 11/Jan/18 ]

The work is still incomplete.

Comment by Spencer Brody (Inactive) [ 29/Nov/17 ]

benety.goh, this ticket has a commit on it but is unassigned on the backlog. Should it be resolved?

Comment by Githook User [ 15/Nov/17 ]

Author:

{'name': 'Benety Goh', 'username': 'benety', 'email': 'benety@mongodb.com'}

Message: SERVER-29200 remove references to OplogEntry::raw from SyncTailTest
Branch: master
https://github.com/mongodb/mongo/commit/740921198a324e2b6c6d68e51a678a1f863dda15

Comment by Judah Schvimer [ 16/May/17 ]

We should attempt to fully remove the raw field if possible and just use the IDL's serializer when necessary.

Generated at Thu Feb 08 04:20:10 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.