[SERVER-29200] Limit access to OplogEntry::raw Created: 15/May/17 Updated: 30/Oct/23 Resolved: 16/Jan/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 3.7.2 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Judah Schvimer | Assignee: | Benety Goh |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | neweng, todo_in_code | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Sprint: | Repl 2018-01-29 | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
(1/16/2018 update) SyncTail::raw still refers to this field. This work is captured in SERVER-32728. The public "raw" member is used in a lot of places. It should be made private and replaced with specific helper functions. |
| Comments |
| Comment by Githook User [ 16/Jan/18 ] |
|
Author: {'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}Message: |
| Comment by Githook User [ 16/Jan/18 ] |
|
Author: {'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}Message: |
| Comment by Githook User [ 16/Jan/18 ] |
|
Author: {'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}Message: remove references to OplogEntry::raw from rollback, prefetchPagesForReplicatedOp() and SyncTail |
| Comment by Githook User [ 16/Jan/18 ] |
|
Author: {'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}Message: remove references to OplogEntry::raw from SyncTail::OpQueue and InitialSyncer |
| Comment by Benety Goh [ 11/Jan/18 ] |
|
The work is still incomplete. |
| Comment by Spencer Brody (Inactive) [ 29/Nov/17 ] |
|
benety.goh, this ticket has a commit on it but is unassigned on the backlog. Should it be resolved? |
| Comment by Githook User [ 15/Nov/17 ] |
|
Author: {'name': 'Benety Goh', 'username': 'benety', 'email': 'benety@mongodb.com'}Message: |
| Comment by Judah Schvimer [ 16/May/17 ] |
|
We should attempt to fully remove the raw field if possible and just use the IDL's serializer when necessary. |