[SERVER-29218] QuerySolutionNode not safely managed in all code paths Created: 15/May/17 Updated: 30/Oct/23 Resolved: 17/May/17 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Querying |
| Affects Version/s: | None |
| Fix Version/s: | 3.5.8 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Justin Seyster | Assignee: | Justin Seyster |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Operating System: | ALL | ||||
| Sprint: | Query 2017-05-29 | ||||
| Participants: | |||||
| Linked BF Score: | 0 | ||||
| Description |
|
ASAN is showing that the CollectionScanNode created by makeCollectionScan is getting leaked. There are a few paths that do not explicitly delete this object: 1) The MatchExpression shallowClone operation just after the CollectionScanNode creation can throw an exception. 2) At least one error path in QueryPlannerAnalysis::analyzeDataAccess() exits early without freeing the "solnRoot" QuerySolutionNode object. |
| Comments |
| Comment by Githook User [ 17/May/17 ] |
|
Author: {u'username': u'jseyster', u'name': u'Justin Seyster', u'email': u'justin.seyster@mongodb.com'}Message: This started with a test failure caused by a QuerySolutionNode getting I may revisit this to use unique_ptrs for all QuerySolutionNode |