[SERVER-29314] fix cyclic dependency between commands and audit libraries Created: 22/May/17  Updated: 30/Oct/23  Resolved: 14/Jun/17

Status: Closed
Project: Core Server
Component/s: Security
Affects Version/s: None
Fix Version/s: 3.5.8

Type: Bug Priority: Major - P3
Reporter: Benety Goh Assignee: Benety Goh
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Repl 2017-05-29, Repl 2017-06-19
Participants:
Linked BF Score: 0

 Description   

Some implementations of the audit function logCommandAuthzCheck() depend on a couple of generic Command functions (parseNs() and redactForLogging()). This introduces an implicit dependency on the 'commands' library where Command is defined, We have a cyclic dependency between the Command and logCommandAuthzCheck() because Command::checkAuthorization() calls logCommandAuthzCheck().



 Comments   
Comment by Githook User [ 25/May/17 ]

Author:

{u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}

Message: SERVER-29314 removed CommandInterface import

This import is no longer necessary now that the downstream changes to implementations of the
audit interface have been completed.
Branch: master
https://github.com/mongodb/mongo/commit/b1d878ebbc9c7c58002e34714db83e748b59bb78

Comment by Githook User [ 25/May/17 ]

Author:

{u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}

Message: SERVER-29314 add CommandInterface to break cyclic dependency between Command and audit implementations
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/c2f5f7f7e0f469ecfaf7ab481a7e95f0a309a43e

Comment by Githook User [ 25/May/17 ]

Author:

{u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}

Message: SERVER-29314 add CommandInterface to break cyclic dependency between Command and audit implementations
Branch: master
https://github.com/mongodb/mongo/commit/bb4d304a75271510250419f7a6edfcb62433eb79

Generated at Thu Feb 08 04:20:29 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.