[SERVER-29351] remove redundant use of BSONObj::storageValidEmbedded from modifier_add_to_set.cpp Created: 24/May/17 Updated: 30/Oct/23 Resolved: 30/May/17 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 3.5.9 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Dianna Hohensee (Inactive) | Assignee: | Dianna Hohensee (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Sprint: | Sharding 2017-05-29, Sharding 2017-06-19 | ||||||||
| Participants: | |||||||||
| Description |
|
There's no need to check that the document is valid here in modifier_add_to_set.cpp when there are similar checks done higher up in exec/update.cpp: different function storageValid used here ---------------- BSONObj::storageValid and BSONObj::storageValidEmbedded were moved from the modifier_* files into ops/update.cpp in this commit. These eventually ended up in exec/update.cpp, moved from ops/update.cpp, by this commit. New storage validation checks were implemented that no longer used BSONObj::storageValid, somewhere between the two commits. modifier_add_to_set.cpp still using BSONObj::storageValid seems like an oversight. ----------------- This task is part of resolving |
| Comments |
| Comment by Githook User [ 30/May/17 ] |
|
Author: {u'username': u'DiannaHohensee', u'name': u'Dianna Hohensee', u'email': u'dianna.hohensee@10gen.com'}Message: |