[SERVER-29464] Get rid of BSONSerializable Created: 06/Jun/17  Updated: 30/Oct/23  Resolved: 08/Jun/17

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 3.5.9

Type: Task Priority: Major - P3
Reporter: Kaloian Manassiev Assignee: Kaloian Manassiev
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Backwards Compatibility: Fully Compatible
Sprint: Sharding 2017-06-19
Participants:
Linked BF Score: 0

 Description   

The BSONSerializable interface is used by the sharding write commands parsing code, but is not necessary in practice since the parsers are templated. So it should be removed.



 Comments   
Comment by Githook User [ 09/Jun/17 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-29464 Fix memory leak in BatchedDeleteRequest and BatchedUpdateRequest
Branch: master
https://github.com/mongodb/mongo/commit/325c09e76d40d440deea17a0f24c360e107c937e

Comment by Githook User [ 09/Jun/17 ]

Author:

{u'name': u'Kaloian Manassiev', u'email': u'kaloianm@mongodb.com'}

Message: SERVER-29464 Get rid of unused code in the write commands parsing
Branch: master
https://github.com/mongodb/mongo/commit/12a3661d030ecc827569cda5842c11b422d285c8

Comment by Githook User [ 08/Jun/17 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-29464 Get rid of BSONSerializable
Branch: master
https://github.com/mongodb/mongo/commit/b2d6f747eb85d303d309f5990ba395eb9a23fa86

Comment by Max Hirschhorn [ 07/Jun/17 ]

Reverted due to the large number of failures this change caused in Evergreen: https://evergreen.mongodb.com/version/mongodb_mongo_master_06369c8cedbb06a554012069c8973423b32d9452#/1.

Comment by Githook User [ 07/Jun/17 ]

Author:

{u'username': u'visemet', u'name': u'Max Hirschhorn', u'email': u'max.hirschhorn@mongodb.com'}

Message: Revert "SERVER-29464 Get rid of BSONSerializable"

This reverts commit 06369c8cedbb06a554012069c8973423b32d9452.
Branch: master
https://github.com/mongodb/mongo/commit/386a788bd9f565c1a4bba46b5b570f7e53e85c7b

Comment by Githook User [ 07/Jun/17 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-29464 Get rid of BSONSerializable
Branch: master
https://github.com/mongodb/mongo/commit/06369c8cedbb06a554012069c8973423b32d9452

Generated at Thu Feb 08 04:20:57 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.