[SERVER-29484] Audit in-header namespace level using statements for correctness and non-pollution Created: 06/Jun/17 Updated: 30/Oct/23 Resolved: 14/Feb/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 3.7.3 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | ADAM Martin (Inactive) | Assignee: | ADAM Martin (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Operating System: | ALL |
| Sprint: | Platforms 2018-02-26 |
| Participants: |
| Description |
|
We have numerous in-header using statements: % grep -r '^using .*;' src/mongo/ | grep '\.h:'|wc -l Some are basic typedefs. Some improperly import external namespace objects into mongo. Filtering for `stdx` which needs to do this, there are just under 100 potential violations: % grep -r '^using .;' src/mongo/ | grep '\.h:' | grep -v 'mongo/stdx/.\.h:' | less|wc -l |
| Comments |
| Comment by Githook User [ 14/Feb/18 ] |
|
Author: {'email': 'adam.martin@10gen.com', 'name': 'ADAM David Alan Martin', 'username': 'adamlsd'}Message: There are some `using std::` using statements in headers that are |