[SERVER-29544] *_WRITE_CONFLICT_RETRY_* uses should be writeConflictRetry calls Created: 09/Jun/17 Updated: 30/Oct/23 Resolved: 07/Jul/17 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Storage |
| Affects Version/s: | 3.5.8 |
| Fix Version/s: | 3.5.10 |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | Nathan Myers | Assignee: | Ian Kuehne |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Sprint: | Storage 2017-07-10 | ||||||||
| Participants: | |||||||||
| Description |
|
Now that we have a function template writeConflictRetry, the 76 uses, in 38 files, of the old MONGO_WRITE_CONFLICT_RETRY_BEGIN / _END macro can be updated to use the new form. |
| Comments |
| Comment by Githook User [ 07/Jul/17 ] |
|
Author: {u'name': u'Ian Kuehne', u'email': u'ian.kuehne@mongodb.com'}Message: |
| Comment by Ian Kuehne [ 07/Jul/17 ] |
|
Reopened: remaining references to macro in comments. |
| Comment by Ian Kuehne [ 07/Jul/17 ] |
|
Oh--well spotted. I'll fix those in a moment. |
| Comment by Nathan Myers [ 06/Jul/17 ] |
|
There are still a couple of mentions of WRITE_CONFLICT_RETRY macros in comments in db/ops/write_ops_exec.cpp, db/catalog/index_create_impl.cpp, db/catalog/capped_utils.cpp and in write_conflict_exception.h itself. |
| Comment by Githook User [ 03/Jul/17 ] |
|
Author: {u'name': u'Ian Kuehne', u'email': u'ian.kuehne@mongodb.com'}Message: |