[SERVER-29552] Fold the assembleResponse implementation into mongod's ServiceEntryPoint Created: 11/Jun/17  Updated: 30/Oct/23  Resolved: 15/Jun/17

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: 3.5.9

Type: Improvement Priority: Major - P3
Reporter: Andrew Morrow (Inactive) Assignee: Andrew Morrow (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Platforms 2017-06-19
Participants:

 Description   

The ServiceEntryPoint for mongod just calls assembleResponse, and is the only remaining caller of assembleResponse. Similarly, assembleResponse is the only remaining caller of runCommands.

We should move the body of assembleResponse directly into the mongod ServiceEntryPointMongod::handleRequest body, and the move runCommands into the unnamed namespace in the same file.



 Comments   
Comment by Githook User [ 15/Jun/17 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-29552 Prune list of direct dependencies for libSEPd
Branch: master
https://github.com/mongodb/mongo/commit/82092c404fd9c26bbcb3fc37ba1af458a1a0b576

Comment by Githook User [ 15/Jun/17 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-29552 Fold runCommands into ServiceEntryPointMongod
Branch: master
https://github.com/mongodb/mongo/commit/3dc746d9f61f8b9bb18c44d64f5e425532ac4304

Comment by Githook User [ 15/Jun/17 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-29552 Fold assembleResponse into ServiceEntryPointMongod
Branch: master
https://github.com/mongodb/mongo/commit/f48f1ca3506de6f376e1b6a6172201bcec5dd04b

Comment by Githook User [ 15/Jun/17 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-29552 Complete the assemble_response library
Branch: master
https://github.com/mongodb/mongo/commit/cf720049672547851498ffbef32b1a19baaf0f11

Generated at Thu Feb 08 04:21:12 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.