[SERVER-29566] link cluster_commands_common.cpp into both mongos and mongod Created: 12/Jun/17  Updated: 30/Oct/23  Resolved: 15/Jun/17

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: 3.5.8
Fix Version/s: 3.5.9

Type: Task Priority: Major - P3
Reporter: Esha Maharishi (Inactive) Assignee: Jessica Yu
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by SERVER-29567 move appendWriteConcernErrorToCmdResp... Closed
Backwards Compatibility: Fully Compatible
Sprint: Sharding 2017-06-19
Participants:

 Description   

The file contains some methods, such as getAllShardedCollectionsForDb, that are used by a command that is moving to the config server.

The file also contains generic methods, such as scatterGather() and establishCursors(), that it may be helpful to have available on mongod in the future.

So, a simple fix is to link cluster_commands_common.cpp into mongod as well.



 Comments   
Comment by Githook User [ 15/Jun/17 ]

Author:

{u'name': u'Jessica Yu', u'email': u'jessicayu@MacBook-Pro-51.local'}

Message: SERVER-29566 link cluster_commands_common.cpp into both mongos and mongod
Branch: master
https://github.com/mongodb/mongo/commit/c85fa667c13b7d3af3521a48dfb76fdfcd429e44

Comment by Andrew Morrow (Inactive) [ 12/Jun/17 ]

Please note that the three sharding libraries s/coreshard, db/s/sharding, and client/sharding_client are currently among the very last libraries participating in cycles. Any move towards a 'sharding API' should incorporate the goal of eliminating the need for cyclic dependencies among these components.

Comment by Kaloian Manassiev [ 12/Jun/17 ]

This file started as a library to contain code used by the sharding commands only. It seems we have accidentally morphed it into more than that. Instead of linking it on both mongod and mongos, how about we create a Sharding API library and move the utilities you are referring to in it?

This would eventually be the main entry point for any code piece which uses sharding.

cc esha.maharishi

Generated at Thu Feb 08 04:21:14 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.