[SERVER-29627] Replace pieces of time_support.h/cpp if they can be implemented using new timezone library Created: 14/Jun/17 Updated: 06/Dec/22 |
|
| Status: | Backlog |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Charlie Swanson | Assignee: | Backlog - Query Execution |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Assigned Teams: |
Query Execution
|
||||||||||||||||
| Sprint: | Query 2017-08-21, Query 2017-09-11 | ||||||||||||||||
| Participants: | |||||||||||||||||
| Description |
|
As part of the review for The following new format specifiers will also be available after this gets merged: %a %b %e |
| Comments |
| Comment by Andy Schwerin [ 26/Jul/17 ] |
|
derick, a bunch of the code for serializing Date_t to strings is used by the diagnostic logging code, and so must be present in the "base" library. This change may require more work than is warranted right now. It's not clear to me why the date/time support library in query is in query at all, and teasing it out of there may be required in order to fix to use it in time_support.h/cpp. From my survey of the code, I think the work items for this ticket would be as follows:
|
| Comment by Charlie Swanson [ 25/Jul/17 ] |
|
derick I think it'd be good to move as much of the date handling as we can into date_time_support. I feel like these things can at least be moved into date_time_support.h, if not re-implemented by using timelib. Also, I think we were planning to make Value::coerceToString() output a date type using the ISO standard, which it currently doesn't do because it leaves off the milliseconds and the 'Z', which I was vaguely hoping was part of this work. I'm happy to spin off a separate ticket for that though, since it seems mostly orthogonal |