[SERVER-29687] Remove dependency on util/net in server_options.h Created: 16/Jun/17  Updated: 30/Oct/23  Resolved: 23/Aug/17

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 3.5.13

Type: Improvement Priority: Major - P3
Reporter: Jonathan Reams Assignee: Andrew Morrow (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Platforms 2017-09-11
Participants:

 Description   

server_options.h included mongo/util/net/listen.h to get a constant int value for its defaults, but many places used this to get getHostName(), getHostNameCached(), prettyHostName(), and IPv6Enabled(). This include should be explicit wherever these functions are used.



 Comments   
Comment by Ramon Fernandez Marina [ 24/Aug/17 ]

Author:

{'username': u'acmorrow', 'name': u'Andrew Morrow', 'email': u'acm@mongodb.com'}

Message:SERVER-29687 Don't include sock.h from options header
Branch:master
https://github.com/mongodb/mongo/commit/730d8768ed9620934f82f17a5076d969a2673db8

Comment by Ramon Fernandez Marina [ 24/Aug/17 ]

Author:

{'username': u'acmorrow', 'name': u'Andrew Morrow', 'email': u'acm@mongodb.com'}

Message:SERVER-29687 Add sock.h header where needed for non-ssl builds
Branch:master
https://github.com/mongodb/mongo/commit/b46b9c5c971372fd81226820e339bc9625b590fb

Generated at Thu Feb 08 04:21:33 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.