[SERVER-29764] benchRun is limited to 128 threads Created: 21/Jun/17  Updated: 06/Dec/22  Resolved: 12/May/20

Status: Closed
Project: Core Server
Component/s: Shell
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major - P3
Reporter: James O'Leary Assignee: Backlog - Server Tooling and Methods (STM) (Inactive)
Resolution: Won't Fix Votes: 0
Labels: tig-benchrun
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
Assigned Teams:
Server Tooling & Methods
Operating System: ALL
Participants:

 Description   

If you attempt to set the number of threads greater than 128, the following invariant is triggered:

[2017/06/20 15:45:04.676] 2017-06-20T13:45:04.637+0000 F -        [thread627] Invariant failure bsonTemplateEvaluator.setId(_id) == BsonTemplateEvaluator::StatusSuccess src/mongo/shell/bench.cpp 683
[2017/06/20 15:45:04.676] 2017-06-20T13:45:04.637+0000 F -        [thread627]



 Comments   
Comment by Ryan Timmons [ 12/May/20 ]

Closing as wont-fix to indicate that there is currently no intention of doing this. New performance workloads are advised to be written in genny rather than benchRun. Please re-open if there is priority for this. Perhaps this change could self-service by an appropriate server team if this is necessary rather than having to go thru the STM prioritization queue.

Comment by David Storch [ 21/Jun/17 ]

Oh man, that's ancient history at this point. If I remember correctly, that restriction had to do with tests which required each worker thread to generate unique sequences of values (something along the lines of reserving bits for the worker thread id to keep things unique). It looks like this is still being used by some of the mongo-perf insert microbenchmarks. For example,

https://github.com/mongodb/mongo-perf/blob/6a1eb58bfc571498dd5d3df523d0c93ee39112d6/testcases/simple_insert.js#L56-L58

Comment by David Daly [ 21/Jun/17 ]

david.storch I believe this is related to code you added. Thoughts?

Generated at Thu Feb 08 04:21:46 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.