[SERVER-29766] Remove rs_rollback_no_uuid files after MongoDB 3.6 Created: 21/Jun/17  Updated: 06/Dec/22

Status: Backlog
Project: Core Server
Component/s: Replication
Affects Version/s: Needs Triage
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Allison Chang Assignee: Backlog - Replication Team
Resolution: Unresolved Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-32193 Remove test coverage for rollbackViaR... Closed
Assigned Teams:
Replication
Participants:

 Description   

After MongoDB 3.6 is released, all oplogs will be required to have a UUID entry, making the no_uuid rollback files unnecessary. rs_rollback_no_uuid.cpp/.h and rs_rollback_no_uuid_test.cpp should all be removed at this point. Additional code that allowed for the old rollback algorithms to work should also be deleted. The failpoint declarations

// Failpoint which causes rollback to hang before finishing.
MONGO_FP_DECLARE(rollbackHangBeforeFinish);
 
// Failpoint which causes rollback to hang and then fail after minValid is written.
MONGO_FP_DECLARE(rollbackHangThenFailAfterWritingMinValid);

should be moved out of roll_back_local_operations.cpp/.h and moved into rs_rollback.cpp after rs_rollback_no_uuid.cpp/.h are deleted. The Sconscript will need to be adjusted accordingly as well.



 Comments   
Comment by Judah Schvimer [ 20/Sep/19 ]

This was almost entirely done in SERVER-32466 (https://github.com/mongodb/mongo/commit/3e4d4d6c8839eea43df01d1eb25de2979f88606c#diff-7fdce52fe8c798fe122cd4ded1b3ccbf). It left a few comments in roll_back_local_operations.h/cpp that could be cleaned up.

Comment by William Schultz (Inactive) [ 12/Oct/17 ]

We can also remove the replica_sets_rollback_refetch_no_uuid test suite and its corresponding sub-directory of tests.

Comment by Allison Chang [ 18/Jul/17 ]

Additionally, we will need to remove

    /**
     * Returns collection info.
     */
    virtual StatusWith<BSONObj> getCollectionInfo(const NamespaceString& nss) const = 0;

from rollback_source.h, as well as its declaration and implementation in rollback_source_impl.h/.cpp

Generated at Thu Feb 08 04:21:46 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.