[SERVER-29908] Libraries db/s/sharding and db/query/query are directly cyclic Created: 28/Jun/17 Updated: 30/Oct/23 Resolved: 13/Aug/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Build, Querying, Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 4.0.3, 4.1.2 |
| Type: | Bug | Priority: | Critical - P2 |
| Reporter: | Andrew Morrow (Inactive) | Assignee: | Kaloian Manassiev |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Operating System: | ALL | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Backport Requested: |
v4.0
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Sprint: | Sharding 2018-02-12, Sharding 2018-02-26, Sharding 2018-03-12, Sharding 2018-04-09, Sharding 2018-04-23, Sharding 2018-05-07, Sharding 2018-05-21, Sharding 2018-06-04, Sharding 2018-06-18, Sharding 2018-07-02, Sharding 2018-07-16, Sharding 2018-07-30, Sharding 2018-08-13, Sharding 2018-08-27 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Linked BF Score: | 0 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Description |
|
The libraries db/s/sharding and db/query/query are directly cyclic. This pulls the sharding subsytem into the dependency tangle identified in |
| Comments |
| Comment by Githook User [ 19/Sep/18 ] |
|
Author: {'name': 'Henrik Edin', 'email': 'henrik.edin@mongodb.com', 'username': 'henrikedin'}Message: (cherry picked from commit 80de0da37b00dbeed576b28a842cb172b6714358)
(cherry picked from commit 2aa65a86193e5d38934a4f2d6b0a8298e2432485)
(cherry picked from commit 60559a00b81293184922b3418a8e56610edf8dd9)
(cherry picked from commit c9c340ad6e9e1f33cb001a8375c62d6b16138c74)
(cherry picked from commit ca04f5bcf9bfa73c9162b3a77225c997c6deec8a)
(cherry picked from commit db1cc80d13d203b6351f5510f7756cc1c7bfc0ea)
(cherry picked from commit 884d232473dca72e0872f0e540d4c3108c1e0b3d)
(cherry picked from commit d91262c4a2ed7d94923c3b1c5ff5d208aa981c73)
(cherry picked from commit e491e284e8066929c8272c96a3128241ab481be8)
Expose the ShardingState properties and move the appendInfo logic to be (cherry picked from commit 24e411d5cd7f64c5b4da25a351529cd1873284b8)
(cherry picked from commit 7a97557ce5bf74dc2b663762b7a5ffb9c958d580)
... and move it into a ShardingInitializationMongoD class, which is Also gets rid of the 'sharding' library, so there is no more library (cherry picked from commit 200c3dc58410d8b3287a2075cc9b2ad085100e83)
... and also remove dependency of MongoS on the replication coordinator (cherry picked from commit fab6864f4edcae7bb304f79e601f1f62cc376a77) |
| Comment by Gregory McKeon (Inactive) [ 16/Aug/18 ] |
|
kaloian.manassiev this is the ticket: BACKPORT-2674. Can you pick that up, or does schwerin need to do it? |
| Comment by Githook User [ 15/Aug/18 ] |
|
Author: {'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}Message: ... and also remove dependency of MongoS on the replication coordinator |
| Comment by Githook User [ 13/Aug/18 ] |
|
Author: {'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}Message: ... and move it into a ShardingInitializationMongoD class, which is Also gets rid of the 'sharding' library, so there is no more library |
| Comment by Githook User [ 01/Aug/18 ] |
|
Author: {'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}Message: |
| Comment by Githook User [ 01/Aug/18 ] |
|
Author: {'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}Message: Expose the ShardingState properties and move the appendInfo logic to be |
| Comment by Githook User [ 27/Jul/18 ] |
|
Author: {'username': 'kaloianm', 'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com'}Message: |
| Comment by Githook User [ 27/Jul/18 ] |
|
Author: {'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}Message: |
| Comment by Andy Schwerin [ 08/Jul/18 ] |
|
I'm happy to work with henrik.edin to hand off sooner, if platforms likes. Things might move faster if I acted primarily as reviewer, given my schedule. Fundamentally, the range deleter and its three intertwined data structures need to be untangled, but it's getting easier. |
| Comment by Gregory McKeon (Inactive) [ 06/Jul/18 ] |
|
schwerin Platforms is worried about this being a blocker for Mobile GA - are we able to hand this off to henrik.edin if we haven't made headway by July 27th? |
| Comment by Githook User [ 23/Apr/18 ] |
|
Author: {'email': 'schwerin@mongodb.com', 'username': 'amschwerin', 'name': 'Andy Schwerin'}Message: Makes MigrationSourceManager a decoration on CollectionShardingState, |
| Comment by Githook User [ 13/Mar/18 ] |
|
Author: {'email': 'kaloian.manassiev@mongodb.com', 'name': 'Kaloian Manassiev', 'username': 'kaloianm'}Message: |
| Comment by Githook User [ 13/Mar/18 ] |
|
Author: {'email': 'kaloian.manassiev@mongodb.com', 'name': 'Kaloian Manassiev', 'username': 'kaloianm'}Message: |
| Comment by Githook User [ 08/Mar/18 ] |
|
Author: {'email': 'kaloian.manassiev@mongodb.com', 'name': 'Kaloian Manassiev', 'username': 'kaloianm'}Message: |
| Comment by Githook User [ 07/Mar/18 ] |
|
Author: {'email': 'kaloian.manassiev@mongodb.com', 'name': 'Kaloian Manassiev', 'username': 'kaloianm'}Message: |
| Comment by Githook User [ 07/Mar/18 ] |
|
Author: {'email': 'kaloian.manassiev@mongodb.com', 'name': 'Kaloian Manassiev', 'username': 'kaloianm'}Message: |
| Comment by Githook User [ 07/Mar/18 ] |
|
Author: {'email': 'kaloian.manassiev@mongodb.com', 'name': 'Kaloian Manassiev', 'username': 'kaloianm'}Message: |
| Comment by Githook User [ 07/Mar/18 ] |
|
Author: {'email': 'kaloian.manassiev@mongodb.com', 'name': 'Kaloian Manassiev', 'username': 'kaloianm'}Message: |
| Comment by Githook User [ 05/Mar/18 ] |
|
Author: {'email': 'kaloian.manassiev@mongodb.com', 'name': 'Kaloian Manassiev', 'username': 'kaloianm'}Message: |
| Comment by Githook User [ 01/Mar/18 ] |
|
Author: {'email': 'kaloian.manassiev@mongodb.com', 'name': 'Kaloian Manassiev', 'username': 'kaloianm'}Message: No functional changes, just cleanup of commands_public.cpp |
| Comment by Githook User [ 26/Feb/18 ] |
|
Author: {'email': 'kaloian.manassiev@mongodb.com', 'name': 'Kaloian Manassiev', 'username': 'kaloianm'}Message: |
| Comment by Githook User [ 22/Feb/18 ] |
|
Author: {'email': 'kaloian.manassiev@mongodb.com', 'name': 'Kaloian Manassiev', 'username': 'kaloianm'}Message: |
| Comment by Githook User [ 13/Feb/18 ] |
|
Author: {'email': 'kaloian.manassiev@mongodb.com', 'name': 'Kaloian Manassiev', 'username': 'kaloianm'}Message: Splits the sharding sybsystem into 3 main libraries, which are currently The libraries are: |
| Comment by Githook User [ 13/Feb/18 ] |
|
Author: {'email': 'kaloian.manassiev@mongodb.com', 'name': 'Kaloian Manassiev', 'username': 'kaloianm'}Message: Revert " This reverts commit da12466c2f109ada2d487db9c6fd92200f5b6b1d. |
| Comment by Githook User [ 13/Feb/18 ] |
|
Author: {'email': 'kaloian.manassiev@mongodb.com', 'name': 'Kaloian Manassiev', 'username': 'kaloianm'}Message: Splits the sharding sybsystem into 3 main libraries, which are currently The libraries are: |
| Comment by Githook User [ 12/Feb/18 ] |
|
Author: {'email': 'kaloian.manassiev@mongodb.com', 'name': 'Kaloian Manassiev', 'username': 'kaloianm'}Message: |
| Comment by Githook User [ 06/Feb/18 ] |
|
Author: {'email': 'kaloian.manassiev@mongodb.com', 'name': 'Kaloian Manassiev', 'username': 'kaloianm'}Message: Also get rid of sharding_catalog_test_fixture since it doesn't provide |
| Comment by Githook User [ 02/Feb/18 ] |
|
Author: {'email': 'kaloian.manassiev@mongodb.com', 'name': 'Kaloian Manassiev', 'username': 'kaloianm'}Message: |
| Comment by Andrew Morrow (Inactive) [ 11/Jan/18 ] |
|
The work done in Note that this is the last remaining library dependency cycle within the codebase. Addressing it will leave us with a DAG for library dependencies. |