[SERVER-29910] Make RoleGraph non-copyable Created: 28/Jun/17 Updated: 30/Oct/23 Resolved: 01/Jul/17 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | 3.5 Desired |
| Fix Version/s: | 3.5.10 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Sara Golemon | Assignee: | Sara Golemon |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Minor Change |
| Sprint: | Platforms 2017-07-10 |
| Participants: |
| Description |
|
Actually copying a structure this size is unnecessarily expensive given how it's actually used. Remove copy-ability and replace with move semantics. Remove swap() method as well, replacing the one usage with a move since it's a local variable that's about to die anyway. |
| Comments |
| Comment by Githook User [ 01/Jul/17 ] |
|
Author: {u'username': u'sgolemon', u'name': u'Sara Golemon', u'email': u'sara.golemon@mongodb.com'}Message: Unrevert and apply MSVC workarounds. |
| Comment by Githook User [ 30/Jun/17 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: Revert " This reverts commit 41cd527620d94a11362f2a5a1aa86643be22d36e. |
| Comment by Sara Golemon [ 30/Jun/17 ] |
|
RoleGraph is now non-copyable. |
| Comment by Githook User [ 30/Jun/17 ] |
|
Author: {u'username': u'sgolemon', u'name': u'Sara Golemon', u'email': u'sara.golemon@mongodb.com'}Message: Changed explicit trivial constructor to `default`. Removed a test which dealt specifically with copyability |