[SERVER-30044] BSONComparator should delete rvalue ref-qualified makeContainer() functions Created: 07/Jul/17 Updated: 30/Oct/23 Resolved: 23/Apr/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | None |
| Fix Version/s: | 4.7.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Kyle Suarez | Assignee: | Drew Paroski |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Query 2020-05-04 |
| Participants: |
| Description |
|
It's very tempting to write
but this would be wrong, as the BSONElementComparator must outlive the container. We should delete the rvalue ref-qualified versions of these functions to stop code like this from compiling. |
| Comments |
| Comment by Githook User [ 23/Apr/20 ] |
|
Author: {'name': 'Drew Paroski', 'email': 'andrew.paroski@10gen.com'}Message: |