[SERVER-30212] Use two phase drop for renameCollection drops Created: 18/Jul/17  Updated: 30/Oct/23  Resolved: 29/Aug/17

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 3.5.13

Type: Task Priority: Major - P3
Reporter: Judah Schvimer Assignee: Benety Goh
Resolution: Fixed Votes: 0
Labels: todo_in_code
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-30496 Add additional testing for rollback o... Closed
is depended on by SERVER-30514 Change default rollbackMethod server ... Closed
Problem/Incident
causes SERVER-30656 Coverity analysis defect 101975: PW.P... Closed
Related
related to SERVER-30963 oplog_test should protect access to l... Closed
related to SERVER-65416 Complete TODO listed in SERVER-30212 Open
related to SERVER-43432 Remove TODO in transport_layer_asio.cpp Backlog
related to SERVER-29959 Fix renameCollection step in rollback... Closed
related to SERVER-30371 Separate renameCollection across DB c... Closed
Backwards Compatibility: Fully Compatible
Sprint: Repl 2017-08-21, Repl 2017-09-11
Participants:
Linked BF Score: 0

 Description   

Both dropTarget and dropSource need to be 2-phase-dropped for rollback.



 Comments   
Comment by Githook User [ 29/Aug/17 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-30212 add unit test for repl::logOp
Branch: master
https://github.com/mongodb/mongo/commit/2d7aef7ca03e3a7153f4e2856ea96a862d88e1de

Comment by Githook User [ 28/Aug/17 ]

Author:

{'username': 'benety', 'name': 'Benety Goh', 'email': 'benety@mongodb.com'}

Message: SERVER-30212 moved test RAII class ForceSupportsDocLocking from d_concurrency_test.cpp to lock_manager_test_help.h
Branch: master
https://github.com/mongodb/mongo/commit/95d9bdf1b9250d4beea8182ee907107fc732d216

Comment by Benety Goh [ 24/Aug/17 ]

Author:

{'username': 'benety', 'email': 'benety@mongodb.com', 'name': 'Benety Goh'}

Message: SERVER-30212 add two phase drop test for renameCollection in a replica set with dropTarget
Branch: master
https://github.com/mongodb/mongo/commit/ef242b283ab331cc4cc953354dd015aa2f1cd3d8

Comment by Benety Goh [ 24/Aug/17 ]

Author:

{'username': 'benety', 'email': 'benety@mongodb.com', 'name': 'Benety Goh'}

Message: SERVER-30212 renameCollectionForApplyOps() supports two phase drop for target collection
Branch: master
https://github.com/mongodb/mongo/commit/3591aed17610d09edaf10428a23d08e35111e69c

Comment by Benety Goh [ 22/Aug/17 ]

Author:

{'username': 'benety', 'email': 'benety@mongodb.com', 'name': 'Benety Goh'}

Message: SERVER-30212 renameCollection() two phase drops target collection
Branch: master
https://github.com/mongodb/mongo/commit/86e26162578c7897da6047e5a6e1c2bc6960a0d4

Comment by Githook User [ 22/Aug/17 ]

Author:

{'username': 'benety', 'email': 'benety@mongodb.com', 'name': 'Benety Goh'}

Message: SERVER-30212 apply_ops_idempotency.js waits for drop-pending collections to be removed
Branch: master
https://github.com/mongodb/mongo/commit/d33d4c43a019e17e3afb8be5fa47382f7566e26c

Comment by Githook User [ 22/Aug/17 ]

Author:

{'username': 'benety', 'email': 'benety@mongodb.com', 'name': 'Benety Goh'}

Message: SERVER-30212 UUIDCatalog::onRenameCollection() defers registering UUID until WUOW is committed
Branch: master
https://github.com/mongodb/mongo/commit/b1a36aaa34f48df1573d76439419552282f18cbf

Comment by Githook User [ 18/Aug/17 ]

Author:

{'username': 'benety', 'email': 'benety@mongodb.com', 'name': 'Benety Goh'}

Message: SERVER-30212 add renameOpTime argument to renameCollectionForApplyOps()

This supports two phase drops for renameCollection when the target collection is
dropped (dropTarget=true).
Branch: master
https://github.com/mongodb/mongo/commit/52007c747ca483bba871c5c71684b18717222019

Comment by Githook User [ 15/Aug/17 ]

Author:

{'username': 'benety', 'email': 'benety@mongodb.com', 'name': 'Benety Goh'}

Message: SERVER-30212 OpObserver::onRenameCollection() returns rename op time
Branch: master
https://github.com/mongodb/mongo/commit/578e5c4f168db90ebb7ec661831363575d801f5b

Comment by Githook User [ 14/Aug/17 ]

Author:

{'username': 'benety', 'email': 'benety@mongodb.com', 'name': 'Benety Goh'}

Message: SERVER-30212 add RenameCollectionOptions
Branch: master
https://github.com/mongodb/mongo/commit/512fcfe0cd29d029c586589a3f1577a40123dc65

Comment by Benety Goh [ 18/Jul/17 ]

This is required to support enhancements to the rollback subsystem.

Generated at Thu Feb 08 04:23:03 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.