[SERVER-30219] Make metadata commands use kLocalReadConcern Created: 18/Jul/17  Updated: 30/Oct/23  Resolved: 12/Feb/18

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: 3.5.10
Fix Version/s: 3.7.2

Type: Task Priority: Major - P3
Reporter: Jessica Yu Assignee: Kaloian Manassiev
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Sharding 2017-07-31, Sharding 2017-08-21, Sharding 2018-01-29, Sharding 2018-02-12, Sharding 2018-02-26
Participants:

 Description   

Currently, moved metadata commands read from config with kMajorityReadConcern, when they should use kLocalReadConcern since they are now on config. To correct this, add read concern as an optional (default kMajorityReadConcern) to catalog client functions and the hierarchy of called functions that lead to querying the config server. In addition, make the mongos commands send kLocalReadConcern to config.



 Comments   
Comment by Githook User [ 12/Feb/18 ]

Author:

{'email': 'kaloian.manassiev@mongodb.com', 'name': 'Kaloian Manassiev', 'username': 'kaloianm'}

Message: SERVER-30219 Make addShard use local read concern when generating the new shard name
Branch: master
https://github.com/mongodb/mongo/commit/001988f53662c402500405ace82a1555899d9f44

Comment by Kaitlin Mahar [ 23/Jan/18 ]

Places I've found that are using non-local RC within configsvr commands and catalog manager:

  1. configsvr_remove_shard_command uses majority in call to getChunks
  2. generateNewShardName uses majority in call to getConfigShard

kaloian.manassiev would either of these have been intentionally majority, or should they be changed to local?

Comment by Kaitlin Mahar [ 22/Jan/18 ]

since this was still marked open, performing a quick audit of all the commands now to make sure they all use local RC.

Comment by Githook User [ 10/Aug/17 ]

Author:

{'name': 'Jessica Yu', 'email': 'jessica.yu@mongodb.com'}

Message: SERVER-30219 Make metadata commands use kLocalReadConcern
Branch: master
https://github.com/mongodb/mongo/commit/e101217eabfaa8d10c1c6cce969fa773ead966f2

Comment by Githook User [ 08/Aug/17 ]

Author:

{'username': 'EshaMaharishi', 'email': 'esha.maharishi@mongodb.com', 'name': 'Esha Maharishi'}

Message: Revert "SERVER-30219 Make metadata commands use kLocalReadConcern"

This reverts commit e101217eabfaa8d10c1c6cce969fa773ead966f2.
Branch: master
https://github.com/mongodb/mongo/commit/a70b206b4d056de139e649e17d7c1ca3a5c79a52

Generated at Thu Feb 08 04:23:04 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.