[SERVER-30240] remove incorrect paragraph from getNextOpTime() comments in oplog.cpp Created: 20/Jul/17  Updated: 30/Oct/23  Resolved: 21/Jul/17

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 3.5.11

Type: Bug Priority: Trivial - P5
Reporter: Benety Goh Assignee: Andy Schwerin
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-15192 Make all logOp listeners rollback-safe Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Participants:

 Description   

The follow paragraph is no longer true and should be removed. We should link this ticket to the SERVER ticket in which this assumption changed.

https://github.com/mongodb/mongo/blob/878e55a460de02de2f0171d3e9e1bcfc12bb80cc/src/mongo/db/repl/oplog.cpp#L148

oplog.cpp

143
/**
144
 * Allocates an optime for a new entry in the oplog, and updates the replication coordinator to
145
 * reflect that new optime.  Returns the new optime and the correct value of the "h" field for
146
 * the new oplog entry.
147
 *
148
 * NOTE: From the time this function returns to the time that the new oplog entry is written
149
 * to the storage system, all errors must be considered fatal.  This is because the this
150
 * function registers the new optime with the storage system and the replication coordinator,
151
 * and provides no facility to revert those registrations on rollback.
152
 */
153
void getNextOpTime(OperationContext* opCtx,
154
                   Collection* oplog,
155
                   ReplicationCoordinator* replCoord,
156
                   ReplicationCoordinator::Mode replicationMode,
157
                   unsigned count,
158
                   OplogSlot* slotsOut) {



 Comments   
Comment by Githook User [ 21/Jul/17 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}

Message: SERVER-30240 Remove obsolete comment in oplog.cpp.

This comment was obsoleted by SERVER-15192.
Branch: master
https://github.com/mongodb/mongo/commit/405b07f373d900e810965a838f1c4bbaf8b16dcb

Generated at Thu Feb 08 04:23:08 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.