[SERVER-30254] Make ThreadPool::join finish remaining tasks on a pristine thread instead of inline Created: 21/Jul/17 Updated: 30/Oct/23 Resolved: 17/Aug/17 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 3.5.12 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Dianna Hohensee (Inactive) | Assignee: | Dianna Hohensee (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||
| Sprint: | Sharding 2017-07-31, Sharding 2017-08-21 | ||||||||||||||||
| Participants: | |||||||||||||||||
| Linked BF Score: | 0 | ||||||||||||||||
| Description |
|
Unit tests can run into trouble when tasks that create OperationContexts are run inline because the testing infrastructure may have already established an OperationContext and a Client cannot have more than one OperationContext associated with it. This is a problem for ShardServerCatalogCacheLoader unit testing, where the unit test ShardServerCatalogCacheLoaderTest inherits from ShardServerTestFixture that provides an operation context. Then the ShardServerCatalogCacheLoader destructor runs join on it's thread pool, which contains tasks that require and create OperationContexts. |
| Comments |
| Comment by Dianna Hohensee (Inactive) [ 17/Aug/17 ] |
|
Moving split_chunk_test re-enablement to a separate ticket, |
| Comment by Dianna Hohensee (Inactive) [ 07/Aug/17 ] |
| Comment by Githook User [ 07/Aug/17 ] |
|
Author: {'username': 'DiannaHohensee', 'email': 'dianna.hohensee@10gen.com', 'name': 'Dianna Hohensee'}Message: |
| Comment by Githook User [ 07/Aug/17 ] |
|
Author: {'username': 'DiannaHohensee', 'email': 'dianna.hohensee@10gen.com', 'name': 'Dianna Hohensee'}Message: Revert " This reverts commit 1cf5b5612d942e948c9a78115fc8980a10bbeca5. |
| Comment by Githook User [ 07/Aug/17 ] |
|
Author: {'username': 'DiannaHohensee', 'email': 'dianna.hohensee@10gen.com', 'name': 'Dianna Hohensee'}Message: |
| Comment by Githook User [ 28/Jul/17 ] |
|
Author: {'email': 'dianna.hohensee@10gen.com', 'username': 'DiannaHohensee', 'name': 'Dianna Hohensee'}Message: |