[SERVER-30387] maxLogSizeKB parameter should only be positive Created: 28/Jul/17 Updated: 02/Mar/20 Resolved: 28/Feb/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code, Logging |
| Affects Version/s: | 3.4.0 |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Kevin Pulo | Assignee: | Henrik Edin |
| Resolution: | Done | Votes: | 1 |
| Labels: | ?, neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Backwards Compatibility: | Minor Change | ||||||||||||||||||||||||
| Sprint: | Sharding 2018-03-12, Sharding 2019-02-25, Sharding 2019-03-11, Sharding 2019-03-25, Dev Tools 2020-03-09 | ||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||
| Description |
|
It's currently possible to set the maxLogSizeKB parameter to 0 or a negative value, neither of which make sense. The parameter variable itself is a signed int, but gets assigned to a size_t (which is unsigned). But it's not possible to use an unsigned type (see |
| Comments |
| Comment by Kevin Pulo [ 02/Mar/20 ] |
|
Ok, thanks for confirming that. I've flagged this for docs downstream attention, since this is a documented parameter. |
| Comment by Kevin Pulo [ 02/Mar/20 ] |
|
Thanks henrik.edin! I notice the validator is "gte: 0", permitting a value of 0. I skimmed the code and it looks like this value is used to inhibit truncation, is that correct? |
| Comment by Henrik Edin [ 28/Feb/20 ] |
|
Fixed by |
| Comment by Kevin Pulo [ 07/Jun/18 ] |
|
|
| Comment by Gregory McKeon (Inactive) [ 19/Jan/18 ] |
|
kevin.pulo If you send us a code review, we'll review it. |