[SERVER-305] ctrl-c in shell should terminate currenct command Created: 22/Sep/09  Updated: 12/Jul/16  Resolved: 22/Feb/10

Status: Closed
Project: Core Server
Component/s: Shell
Affects Version/s: None
Fix Version/s: 1.3.3

Type: Improvement Priority: Minor - P4
Reporter: Dwight Merriman Assignee: Aaron Staple
Resolution: Done Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-323 improved concurrency: read/write lock... Closed
Participants:

 Comments   
Comment by auto [ 22/Feb/10 ]

Author:

{'login': 'astaple', 'name': 'Aaron', 'email': 'aaron@10gen.com'}

Message: Revert "Revert "SERVER-305 record uri on connect""

This reverts commit 149248b4eb1a8f0cbfe28c4d43c4d2664b00b063.
http://github.com/mongodb/mongo/commit/cd1dfe32b0efe7b0faa1db0c8ecc5d9528eac177

Comment by auto [ 22/Feb/10 ]

Author:

{'login': 'astaple', 'name': 'Aaron', 'email': 'aaron@10gen.com'}

Message: Revert "SERVER-305 record uri on connect"

This reverts commit ae80a66ff8d30bc9785d12a5f9d8fafd0bc37e2a.
http://github.com/mongodb/mongo/commit/149248b4eb1a8f0cbfe28c4d43c4d2664b00b063

Comment by auto [ 22/Feb/10 ]

Author:

{'login': 'astaple', 'name': 'Aaron', 'email': 'aaron@10gen.com'}

Message: SERVER-305 make test work in parallel suite
http://github.com/mongodb/mongo/commit/8f5ee9d1ba1ade5321771db14d7b7ac6419a35c8

Comment by auto [ 22/Feb/10 ]

Author:

{'login': 'astaple', 'name': 'Aaron', 'email': 'aaron@10gen.com'}

Message: SERVER-305 record uri on connect
http://github.com/mongodb/mongo/commit/ae80a66ff8d30bc9785d12a5f9d8fafd0bc37e2a

Comment by Aaron Staple [ 18/Feb/10 ]

I should record the uri on connect, not on scope creation

Comment by auto [ 18/Feb/10 ]

Author:

{'login': 'astaple', 'name': 'Aaron', 'email': 'aaron@10gen.com'}

Message: SERVER-305 forgot to commit test before
http://github.com/mongodb/mongo/commit/5c8d2d1538e27a2f6e112b9b6e6bf16d2276be94

Comment by auto [ 17/Feb/10 ]

Author:

{'login': 'astaple', 'name': 'Aaron', 'email': 'aaron@10gen.com'}

Message: SERVER-305 shell kills in progress operations on clean exit
http://github.com/mongodb/mongo/commit/56150cc727b8faabbb255daa74b3b2bdbb912852

Comment by Dwight Merriman [ 26/Jan/10 ]

this can be deferred for any time in the near future as i think the right way to do now would be killOp, and that is complicated

we should make sure if the shell is printing a very large set of output, that is interruptible by ctrl-c, which may already be true not sure.

Comment by Eliot Horowitz (Inactive) [ 26/Jan/10 ]

No - it should use the same mechanism as killOp()
so many things support that don't support yielding.

Comment by Aaron Staple [ 26/Jan/10 ]

I'm assuming this is only supposed to work for operations that have yield implemented (update & delete according to another jira). Is that correct?

If the update/delete is being called indirectly via a command, I think we shouldn't allow interruption to avoid inconsistent data resulting from a partially completed command.

Comment by Eliot Horowitz (Inactive) [ 20/Oct/09 ]

this can't happen until after concurrency - so moving for now

Comment by Dwight Merriman [ 15/Oct/09 ]

this is tricky to implement as kill current op might kill someone else's operation.

Generated at Thu Feb 08 02:53:40 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.